test(native): add regression test for crates/ directory not being ignored#1680
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect_files.rsverifying that files under acrates/directory are collected by the native engine"crates"entry that was mistakenly inDEFAULT_IGNORE_DIRS, causing the native engine to silently skip all files under anycrates/directory in user repositories (while the WASM engine did not — parity divergence)"crates"fromDEFAULT_IGNORE_DIRSlanded in commit53cc57d5(shipped in v3.14.x); this PR adds the regression test coverage that was missingTest plan
collect_does_not_skip_crates_dirpasses:cargo test collect_does_not_skip_crates_dirnpx vitest run tests/integration/build-parity.test.tsDEFAULT_IGNORE_DIRSincollect_files.rsdoes not contain"crates"(verified at commit53cc57d5)IGNORE_DIRSinconstants.tsdoes not contain"crates"(verified)Fixes #1674