-
Notifications
You must be signed in to change notification settings - Fork 16
feat(dynamic-calls): phase 6 — C#/Swift/Elixir/Lua long-tail dynamic dispatch #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
30a53e4
feat(dynamic-calls): phase 6 — C#/Swift/Elixir/Lua long-tail dynamic …
carlos-alm d0bb2f0
fix: resolve merge conflicts with main
carlos-alm 080e759
fix: address review — NSSelectorFromString precision, python receiver…
carlos-alm e8f8df5
fix(dynamic-calls): fix Swift string extraction, Lua key lookup, dupl…
carlos-alm 84c3e6b
fix: resolve merge conflicts with main (phase 3 merged)
carlos-alm 4f7dea6
fix: resolve merge conflicts with main
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
tests/benchmarks/resolution/fixtures/dynamic-csharp/Reflection.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Phase 6: C# reflection patterns | ||
| // GetMethod("name") → reflection kind | ||
| // method.Invoke() → unresolved-dynamic | ||
| using System.Reflection; | ||
|
|
||
| public class Reflection { | ||
| public static string Greet(string name) => $"Hello, {name}"; | ||
|
|
||
| // type.GetMethod("Greet") — reflection kind, resolvable in theory | ||
| public static MethodInfo RunGetMethod(Type type) { | ||
| return type.GetMethod("Greet"); | ||
| } | ||
|
|
||
| // method.Invoke(target, args) — unresolved-dynamic | ||
| public static object RunInvoke(MethodInfo method, object target) { | ||
| return method.Invoke(target, new object[] { "world" }); | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
tests/benchmarks/resolution/fixtures/dynamic-csharp/expected-edges.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "$schema": "../../expected-edges.schema.json", | ||
| "language": "csharp", | ||
| "description": "Phase 6 C# fixture: GetMethod resolved as reflection; Invoke flagged. Methods class-qualified in DB → 0% recall until RES-3.", | ||
| "edges": [ | ||
| { | ||
| "source": { "name": "Reflection.RunGetMethod", "file": "Reflection.cs" }, | ||
| "target": { "name": "Reflection.Greet", "file": "Reflection.cs" }, | ||
| "kind": "calls", | ||
| "mode": "dynamic", | ||
| "notes": "type.GetMethod('Greet') — reflection kind; 0% recall because DB uses class-qualified name" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BFS starts from the entire
call_expressionnode and accepts the firstline_string_literalorstring_literalit finds anywhere in the subtree. For code likeNSSelectorFromString(generateSelector("greet"))orNSSelectorFromString(dict["greet"]), the BFS descends into the nested call/subscript and extracts"greet"as if it were the directly-passed selector. This creates a false-positivereflectionedge pointing togreetwhen the actual runtime selector is not statically knowable. The fix is to look only at the direct arguments of the call rather than BFS-ing the entire subtree.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — replaced the BFS over the entire call_expression subtree with a direct argument inspection. The new implementation walks only the direct children of the argument_list (or call_suffix/value_arguments), stopping at the first real argument. Nested string literals inside sub-expressions (e.g. NSSelectorFromString(generateSelector("greet"))) are no longer extracted.