chore(schema): add commit to the CoreGenericRepository protocol [IFC-2954] - #1272
Open
ogenstad wants to merge 1 commit into
Open
chore(schema): add commit to the CoreGenericRepository protocol [IFC-2954]#1272ogenstad wants to merge 1 commit into
ogenstad wants to merge 1 commit into
Conversation
…2954] Regenerated from the Infrahub core schema definitions, where commit is now declared on the CoreGenericRepository generic in addition to the two concrete repository kinds.
Deploying infrahub-sdk-python with
|
| Latest commit: |
2c58b4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb2a75f5.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-generic-repository-commi.infrahub-sdk-python.pages.dev |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #1272 +/- ##
=================================================
Coverage 84.16% 84.16%
=================================================
Files 147 147
Lines 13045 13047 +2
Branches 1930 1930
=================================================
+ Hits 10979 10981 +2
Misses 1503 1503
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ajtmccarty
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerated
infrahub_sdk/protocols.pysoCoreGenericRepository(and itsSynccounterpart) declarescommit: StringOptional.This goes hand in hand with opsmill/infrahub#10387, but I'd want to merge this PR first.
Why
The Infrahub core schema now defines
commiton theCoreGenericRepositorygeneric, in addition to the two concrete repository kinds that already declared it.protocols.pyis generated from those definitions byinvoke backend.generatein the Infrahub repository, so this file has to move with them.Both concrete kinds continue to override the attribute with their own branch scope (
localforCoreRepository,awareforCoreReadOnlyRepository), so no runtime behaviour changes for either.Notes
invoke backend.validate-generatedthere runsgit -C python_sdk diff --exit-code infrahub_sdk/protocols.py, which stays red until the submodule pointer includes this commit.Summary by cubic
Declare commit on the
CoreGenericRepositoryandCoreGenericRepositorySyncprotocols to align the SDK with the updated core schema and allow generic-typed repositories to expose commit. Previously the generic lacked this attribute; now it isStringOptional. Concrete kinds still override it, so runtime behavior does not change.infrahub_sdk/protocols.pyonly; no hand-written logic or changelog.Written for commit 2c58b4b. Summary will update on new commits.