[#664] Today 탭을 TodayTab 모듈로 분리한다#692
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 풀러퀘스트는 Presentation 모듈에서 TodayTab 및 TodayTabTests를 별도의 타겟으로 분리하고, PresentationShared를 프레임워크로 변경하는 등 아키텍처 구조를 개선하였습니다. 이에 따라 관련 뷰, 코디네이터, 테스트 코드 및 README 문서가 업데이트되었습니다. 리뷰 피드백으로는 TodayTabTests 타겟에 PresentationShared 의존성을 명시적으로 추가할 것과, 런타임 크래시 방지를 위해 하위 피처(TodayFeature)에 애널리틱스 추적 의존성을 직접 주입하는 대신 코디네이터나 부모 피처에서 처리하도록 구조를 개선할 것을 제안합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
Today 탭의 화면, TCA feature, coordinator, route, 테스트 소유권을
Presentation에서TodayTabtarget으로 분리📝 작업 내용
📌 요약
TodayTab,TodayTabTeststarget 추가Application/Presentation/TodayTab하위로 이동MainView가TodayTab을 import해 Today 탭 흐름을 조립하도록 정리README.md와 Tuist 모듈 그래프를 현재 target 구조에 맞게 갱신🔍 상세
TodayFeature,TodayFeature+State,TodayView,TodayViewCoordinator를TodayTab/Sources로 이동TodayRoute,TodayTodoItem을 Today 탭 소유 타입으로 정리TodayTabTeststarget을 추가하고 기존 Today 테스트를TodayTab/Tests로 이동Presentationtarget은 tab shell/root composition을 유지하고TodayTab에 의존하도록 정리TodayTab은PresentationShared,Domain,Core만 참조하도록 의존 방향 유지PresentationShared는TodayTabTests실행 시 test bundle 로드가 가능하도록 framework product로 정리TodayTabsource/test 전용 SwiftLint 설정 추가docs/graph.png갱신📸 영상 / 이미지 (Optional)