[#683] timeZone 동기화 요청을 사용자와 timeZone 기준으로 제한한다#685
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 사용자의 타임존을 동기화하는 UserTimeZoneSyncHandler를 개선하여, 로그인 세션 변경 및 포그라운드 진입 시 중복 동기화를 방지하고 필요한 경우에만 동기화하도록 로직을 리팩토링하고 관련 테스트 코드를 추가합니다. 리뷰어는 AppDelegate에서 UIApplication.willEnterForegroundNotification을 별도로 구독하는 대신 기존의 applicationWillEnterForeground(_:) 생명주기 메서드 내에서 직접 이벤트를 처리하고, 불필요한 @objc 메서드를 제거할 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
foreground 복귀와 로그인 세션 전이에서 timeZone 동기화 요청을 유지하되, 동일
(uid, timeZoneIdentifier)조합의 반복 DB write 방지📝 작업 내용
📌 요약
UserTimeZoneSyncHandler동기화 기준을 로그인 세션 이벤트와 App layer timeZone 요청 이벤트로 조정UserTimeZoneSyncHandlerTests추가🔍 상세
UserTimeZoneSyncHandler에서 UIKit 의존성 제거AuthService.observeSignedIn()관찰 추가lastSyncedKey초기화updateUserTimeZone()성공 후에만(uid, timeZoneIdentifier)캐시 갱신AppDelegate에서UIApplication.willEnterForegroundNotification수신 후.didRequestUserTimeZoneSync전달검증
build_sim은 기존ComposableArchitecture.Scope.initlinker 오류로 실패📸 영상 / 이미지 (Optional)
없음