Skip to content

[#681] 웹페이지 삭제가 실패하는 현상을 해결한다#682

Merged
opficdev merged 2 commits into
developfrom
fix/#681-delete-webpage
Jul 3, 2026
Merged

[#681] 웹페이지 삭제가 실패하는 현상을 해결한다#682
opficdev merged 2 commits into
developfrom
fix/#681-delete-webpage

Conversation

@opficdev

@opficdev opficdev commented Jul 3, 2026

Copy link
Copy Markdown
Owner

🔗 연관된 이슈

🎯 의도

WebPage 삭제/복구 요청에서 Firestore document id가 REST path 구성 중 중복 인코딩되어 Functions가 실제 문서를 찾지 못하는 문제 해결

📝 작업 내용

📌 요약

  • WebPage 삭제/복구 endpoint에서 Firestore document id를 재인코딩하지 않도록 수정
  • WebPage 삭제/복구 endpoint path 생성 테스트 추가

🔍 상세

  • WebPage id는 저장 시점에 이미 percent-encoded된 Firestore document id이므로 endpoint path 구성 시 그대로 사용하도록 변경
  • Todo/PushNotification endpoint의 기존 path segment 인코딩 로직은 유지

📸 영상 / 이미지 (Optional)

@opficdev opficdev self-assigned this Jul 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the requestWebPageDeletion and undoWebPageDeletion endpoints in FunctionAPIEndpoint.swift to use the raw id directly, preventing double percent-encoding of Firestore document IDs. Corresponding unit tests have been added in FunctionAPIEndpointTests.swift to verify this behavior, and the marketing version was bumped in Version.xcconfig. Since the only review comment pertained to version number configurations, it has been filtered out, and there is no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@opficdev opficdev merged commit fb56007 into develop Jul 3, 2026
6 checks passed
@opficdev opficdev deleted the fix/#681-delete-webpage branch July 3, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

웹페이지 삭제가 실패하는 현상을 해결한다

1 participant