Reduce repeated favorite queries while serializing API v3 project collections. - #24948
Open
haseebeqx wants to merge 1 commit into
Open
Conversation
- optimize project collection serialization by bulk-loading the current user’s favorite state - avoids repeated Favorite queries when rendering each project’s favor/disfavor links and favorited property
haseebeqx
commented
Aug 25, 2026
| end | ||
|
|
||
| def eager_load_for_element_decorator? | ||
| true |
Contributor
Author
There was a problem hiding this comment.
Project loading uses custom wrapper logic beyond the representer’s declarative Rails eager-load configuration. Returning true ensures that wrapper always runs for the paginated project relation.
Contributor
Author
|
@oliverguenther Please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing
GET /api/v3/projectscallsProject#favorited_by?while building each project’s favorite links and favorited property. This resulted in a separate favorite existence query for every project in the collection.In the profiled workload, 50 favorite existence queries were issued for a page containing 50+ projects.
Changes
favorited_by?uses the preloaded value when called for that user. Calls for another user, or without preloadeddata, continue to delegate to the underlying project model.
current user to it.
Performance
Measured in production mode against:
The dataset contained 62 active projects, with 50 returned per request. The observed values are medians from five runs per state in a local environment using a system-admin API key
Merge checklist