Skip to content

[JIM-169] Error message for jira import runs do not wrap in the table cell - #24945

Merged
ba1ash merged 1 commit into
release/17.8from
bug/jim-169-error-message-for-jira-import-runs-do-not-wrap-in-the-table-cell
Aug 26, 2026
Merged

[JIM-169] Error message for jira import runs do not wrap in the table cell#24945
ba1ash merged 1 commit into
release/17.8from
bug/jim-169-error-message-for-jira-import-runs-do-not-wrap-in-the-table-cell

Conversation

@HDinger

@HDinger HDinger commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/JIM-169

What are you trying to accomplish?

Use ExpandableTextComponent for inline error message

@HDinger HDinger modified the milestones: 17.9.x, 17.8.x Aug 25, 2026
@HDinger
HDinger requested a review from ba1ash August 25, 2026 13:03
@HDinger
HDinger force-pushed the bug/jim-169-error-message-for-jira-import-runs-do-not-wrap-in-the-table-cell branch from 33c12ef to 2b6ccc0 Compare August 25, 2026 13:04
@HDinger

HDinger commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ba1ash

Could you please have a look at this? I did not manage to setup this up locally so I could not really check it yet..

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/work_packages/table/queries/parent_field_ranking_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24945, linked for reference only):

- `rspec ./spec/features/work_packages/table/queries/parent_field_ranking_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #24945. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24945 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @HDinger to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @HDinger, and request a review from @HDinger.
On every commit, set @HDinger as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@ba1ash

ba1ash commented Aug 26, 2026

Copy link
Copy Markdown
Member
image

@ba1ash ba1ash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Big thanks @HDinger

@ba1ash
ba1ash merged commit 38e7559 into release/17.8 Aug 26, 2026
14 checks passed
@ba1ash
ba1ash deleted the bug/jim-169-error-message-for-jira-import-runs-do-not-wrap-in-the-table-cell branch August 26, 2026 06:52
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants