Skip to content

[COMMS-972] Support "observed in" versions in subject auto-generation - #24940

Draft
thykel wants to merge 3 commits into
devfrom
task/COMMS-972-subject-auto-generation-tokenpropertymap
Draft

[COMMS-972] Support "observed in" versions in subject auto-generation#24940
thykel wants to merge 3 commits into
devfrom
task/COMMS-972-subject-auto-generation-tokenpropertymap

Conversation

@thykel

@thykel thykel commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Adapted from #24916.

Ticket

https://community.openproject.org/projects/FND/work_packages/COMMS-972

What are you trying to accomplish?

Follow-up to #24461, this time for Observed in Versions.

This change enables the Observed in versions field to be used in automatic work package subject patterns. Users can now add the observed_in_versions attribute as a placeholder when configuring subject patterns for work package types, making this field available for subject auto-generation in the same way as target versions.

Also, while at it, update the README docs that were already missing target versions.

Screenshots

N/A

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/projects/creation_wizard/project_creation_wizard_spec.rb[1:8:2]
  • rspec ./spec/features/work_packages/table/queries/parent_field_ranking_spec.rb[1:1]
  • rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:1]
  • rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24940, linked for reference only):

- `rspec ./spec/features/projects/creation_wizard/project_creation_wizard_spec.rb[1:8:2]`
- `rspec ./spec/features/work_packages/table/queries/parent_field_ranking_spec.rb[1:1]`
- `rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:1]`
- `rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:2]`

Treat this as a standalone task, unrelated to PR #24940. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24940 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @thykel to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @thykel, and request a review from @thykel.
On every commit, set @thykel as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@thykel thykel changed the title [COMMS-972] Subject auto-generation (TokenPropertyMapper) support [COMMS-972] Support "observed in" versions in subject auto-generation Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploying openproject with PullPreview

Field Value
Latest commit a26295d
Job deploy
Status ✅ Deploy successful
Preview URL https://pr-24940-comms-972-subject-ip-91-99-210-231.my.opf.run:443

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant