feat(resolver): olm.constraint property and compound constraints#2418
Merged
openshift-merge-robot merged 1 commit intoDec 14, 2021
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
do-not-merge/work-in-progress
Member
Author
|
/cc @joelanford |
estroz
force-pushed
the
feat/compound-constraint-gated
branch
from
October 13, 2021 18:37
e12a395 to
be8bd26
Compare
estroz
force-pushed
the
feat/compound-constraint-gated
branch
4 times, most recently
from
December 3, 2021 19:05
46b0733 to
693d013
Compare
estroz
changed the title
olm.constraint property and compound constraints
estroz
marked this pull request as ready for review
December 3, 2021 19:07
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
I'm in the process of adding resolver unit tests for compound constraints. |
perdasilva
reviewed
Dec 3, 2021
perdasilva
reviewed
Dec 3, 2021
estroz
force-pushed
the
feat/compound-constraint-gated
branch
from
December 3, 2021 19:27
693d013 to
e09bd8e
Compare
dinhxuanvu
requested changes
Dec 6, 2021
dinhxuanvu
left a comment
dinhxuanvu
left a comment
Member
There was a problem hiding this comment.
Just took a quick glance. Will do further review later.
estroz
force-pushed
the
feat/compound-constraint-gated
branch
2 times, most recently
from
December 10, 2021 00:06
c9e0398 to
0a2da9c
Compare
estroz
commented
Dec 10, 2021
estroz
force-pushed
the
feat/compound-constraint-gated
branch
2 times, most recently
from
December 10, 2021 22:19
fc37004 to
2060d89
Compare
estroz
commented
Dec 10, 2021
|
|
||
| func DependencyPredicates(properties []*api.Property) ([]cache.Predicate, error) { | ||
| // predicateConverter configures olm.constraint value -> predicate conversion for the resolver. | ||
| type predicateConverter struct{} |
Member
Author
There was a problem hiding this comment.
This will contain fields when CEL is added.
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz
force-pushed
the
feat/compound-constraint-gated
branch
from
December 10, 2021 22:30
2060d89 to
ba9f369
Compare
5 tasks
dinhxuanvu
approved these changes
Dec 14, 2021
dinhxuanvu
left a comment
dinhxuanvu
left a comment
Member
There was a problem hiding this comment.
The PR looks good.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
5 tasks
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
olm.constraintdependency property to resolverall,any,noneconstraint typesMotivation for the change: compound dependency constraints (see operator-framework/enhancements#97).
Reviewer Checklist
/doc/kind feature