Skip to content

🌱 fix(ci): pr title check#2546

Merged
openshift-merge-bot[bot] merged 2 commits intooperator-framework:mainfrom
camilamacedo86:fix-pr-tile-checl
Mar 9, 2026
Merged

🌱 fix(ci): pr title check#2546
openshift-merge-bot[bot] merged 2 commits intooperator-framework:mainfrom
camilamacedo86:fix-pr-tile-checl

Conversation

@camilamacedo86
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 15:34
@openshift-ci openshift-ci bot requested review from joelanford and perdasilva March 9, 2026 15:34
@netlify
Copy link

netlify bot commented Mar 9, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 079b3a4
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69aefad55b059400083b2d7a
😎 Deploy Preview https://deploy-preview-2546--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a custom CI check to enforce PR title conventions (emoji prefix, no issue/PR numbers) via a repo script, replacing the previous third-party action.

Changes:

  • Add hack/verify-pr-title.sh to validate and normalize PR titles.
  • Update PR title workflow to run the new script on pull_request_target events.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
hack/verify-pr-title.sh Adds bash logic to normalize/validate PR titles (emoji prefix, no #123).
.github/workflows/pr-title.yaml Replaces external action with a checkout + script execution workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI review requested due to automatic review settings March 9, 2026 16:07
@camilamacedo86 camilamacedo86 force-pushed the fix-pr-tile-checl branch 5 times, most recently from 4a357b8 to fdaf14c Compare March 9, 2026 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 9, 2026 16:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026
@perdasilva
Copy link
Contributor

perdasilva commented Mar 9, 2026

we can override the failures in the experimental-e2e for this PR. These are fixed in #2547

@tmshort
Copy link
Contributor

tmshort commented Mar 9, 2026

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026
@tmshort
Copy link
Contributor

tmshort commented Mar 9, 2026

we can override the failures in the experimental-e2e for this PR. These are fixed in #2547

Overrides are a strange beast. Lets' get 2547 in

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented Mar 9, 2026

/override experimental-e2e

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2026

@tmshort: Overrode contexts on behalf of tmshort: experimental-e2e

Details

In response to this:

/override experimental-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort
Copy link
Contributor

tmshort commented Mar 9, 2026

/override "Verify PR title"

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2026

@tmshort: Overrode contexts on behalf of tmshort: Verify PR title

Details

In response to this:

/override "Verify PR title"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e0fce0e into operator-framework:main Mar 9, 2026
37 of 41 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-pr-tile-checl branch March 10, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants