🌱 fix(ci): pr title check#2546
🌱 fix(ci): pr title check#2546openshift-merge-bot[bot] merged 2 commits intooperator-framework:mainfrom
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6767940 to
660c2ba
Compare
There was a problem hiding this comment.
Pull request overview
Introduces a custom CI check to enforce PR title conventions (emoji prefix, no issue/PR numbers) via a repo script, replacing the previous third-party action.
Changes:
- Add
hack/verify-pr-title.shto validate and normalize PR titles. - Update PR title workflow to run the new script on
pull_request_targetevents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| hack/verify-pr-title.sh | Adds bash logic to normalize/validate PR titles (emoji prefix, no #123). |
| .github/workflows/pr-title.yaml | Replaces external action with a checkout + script execution workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
660c2ba to
2cfab40
Compare
2cfab40 to
ba26e8f
Compare
4a357b8 to
fdaf14c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
fdaf14c to
84ed066
Compare
84ed066 to
1d95782
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
/lgtm |
|
we can override the failures in the experimental-e2e for this PR. These are fixed in #2547 |
|
/approve |
Overrides are a strange beast. Lets' get 2547 in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override experimental-e2e |
|
@tmshort: Overrode contexts on behalf of tmshort: experimental-e2e DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Verify PR title" |
|
@tmshort: Overrode contexts on behalf of tmshort: Verify PR title DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e0fce0e
into
operator-framework:main
No description provided.