🐛 Add delete ClusterExtensionRevision perm#2545
🐛 Add delete ClusterExtensionRevision perm#2545openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds the missing delete RBAC verb for clusterextensionrevisions to the operator-controller’s ClusterRole so it can prune archived revisions.
Changes:
- Added
deletepermission forclusterextensionrevisionsin the experimental manifest. - Added the same permission in the experimental E2E manifest.
- Added the same permission in the Helm chart ClusterRole template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| manifests/experimental.yaml | Grants delete on clusterextensionrevisions for deployed experimental installs. |
| manifests/experimental-e2e.yaml | Grants delete on clusterextensionrevisions for E2E test installs. |
| helm/olmv1/templates/rbac/clusterrole-operator-controller-manager-role.yml | Keeps Helm-deployed RBAC in sync by including the delete verb. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm also having failures pulling down |
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
fixup-cer-perms
branch
from
edf9405 to
6f92299
Compare
|
/lgtm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
+ Coverage 68.58% 68.60% +0.02%
==========================================
Files 131 131
Lines 9330 9330
==========================================
+ Hits 6399 6401 +2
+ Misses 2439 2438 -1
+ Partials 492 491 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/override codecov/project Not sure why it's still running... |
|
@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override codecov/project |
|
@tmshort: Overrode contexts on behalf of tmshort: codecov/project DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 6f23a79
into
operator-framework:main
Signed-off-by: Per G. da Silva <pegoncal@redhat.com> Co-authored-by: Per G. da Silva <pegoncal@redhat.com>
Description
Adds missing
deleteClusterExtensionRevision permission to operator-controller service account. This is required because the controller also manages the number of archived revisions by deleting older revisions to keep maintain a maximum number of archived revisions on the cluster.Reviewer Checklist