✨Namespace and PVC probes by dtfranz · Pull Request #2535 · operator-framework/operator-controller

dtfranz · 2026-03-03T15:07:15Z

Adds readiness probing via CEL for namespaces and PVCs, to prevent subsequent phases from installing until their readiness checks have passed. Also adds e2e coverage via direct CER creation.

Description

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

netlify · 2026-03-03T15:07:21Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`be95970`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69aa40c8c1ceab00082c056b
😎 Deploy Preview	https://deploy-preview-2535--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Adds readiness probing for additional Kubernetes resource types (Namespaces and PVCs) using CEL-based probes in the ClusterExtensionRevision reconciliation flow, and extends the e2e framework + scenarios to validate direct CER application and phase-blocking behavior when probes fail.

Changes:

Add CEL readiness probes for Namespace (Active) and PersistentVolumeClaim (Bound) and wire them into the CER progress probe chain.
Extend e2e step framework to support direct ClusterExtensionRevision application and scenario templating via ${CER_NAME}.
Add new e2e feature coverage for CER install success and probe-driven phase progression/halting (PVC scenarios), plus required RBAC.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/e2e/steps/testdata/rbac-template.yaml	Grants e2e SA permissions for PV/PVC resources needed by new scenarios.
test/e2e/steps/steps.go	Adds `${CER_NAME}` templating and helper to fetch CER objects; expands step matching for “not installed”.
test/e2e/steps/hooks.go	Extends scenario context with CER name/state and updates cleanup behavior.
test/e2e/features/revision.feature	New e2e feature validating direct CER apply + probe gating for PVC phases.
test/e2e/README.md	Documents the new `${CER_NAME}` scenario variable.
internal/operator-controller/controllers/clusterextensionrevision_controller.go	Initializes and registers CEL probes for Namespace/PVC readiness in CER reconcile options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextensionrevision_controller.go

test/e2e/steps/hooks.go

test/e2e/steps/steps.go

internal/operator-controller/controllers/clusterextensionrevision_controller.go

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/e2e/steps/steps.go

codecov · 2026-03-03T16:21:01Z

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.56%. Comparing base (55473d8) to head (be95970).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...controllers/clusterextensionrevision_controller.go	64.70%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
- Coverage   68.62%   68.56%   -0.07%     
==========================================
  Files         131      131              
  Lines        9288     9304      +16     
==========================================
+ Hits         6374     6379       +5     
- Misses       2427     2436       +9     
- Partials      487      489       +2

Flag	Coverage Δ
e2e	`42.28% <0.00%> (-0.06%)`	⬇️
experimental-e2e	`51.88% <64.70%> (-0.15%)`	⬇️
unit	`53.72% <64.70%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/e2e/features/revision.feature

internal/operator-controller/controllers/clusterextensionrevision_controller.go

test/e2e/steps/steps.go

pedjak

not sure if for this PR is necessary to expose direct creation of CERs, instead of going through CE and appropriate bundles.

internal/operator-controller/controllers/clusterextensionrevision_controller.go

pedjak · 2026-03-04T20:47:52Z

test/e2e/features/revision.feature

+    And ServiceAccount "olm-sa" with needed permissions is available in ${TEST_NAMESPACE}
+
+  @BoxcutterRuntime
+  Scenario:  Install simple revision


how is this scenario related to the logic introduced in PR? We have plenty of scenarios under install.feature that install exactly these resources.

IMO it's an easy way to prove that CERs can be used to install content without a ClusterExtension owner. I thought this was necessary since we had discussed the possibility that users might (but probably won't) use the API directly - plus its runtime is only about 1.5 seconds. I can remove it if you think it's unnecessary.

internal/operator-controller/controllers/clusterextensionrevision_controller.go

test/e2e/features/revision.feature

pedjak · 2026-03-04T20:51:20Z

test/e2e/steps/hooks.go

-		for _, r := range forDeletion {
-			if _, err := k8sClient("delete", r.kind, r.name, "--ignore-not-found=true"); err != nil {
-				logger.Info("Error deleting resource", "name", r.name, "namespace", sc.namespace, "stderr", stderrOutput(err))
+	for _, r := range forDeletion {


how is this change related to the PR?

Before the change, in my test runs, the after hook would only delete a single item in forDeletion (the clusterextension) and would leave remaining resources (namespaces and owner-less clusterextensionrevisions) on the cluster. This fixed that and also made the deletion run more quickly by executing them asynchronously.

dtfranz · 2026-03-05T02:07:40Z

not sure if for this PR is necessary to expose direct creation of CERs, instead of going through CE and appropriate bundles.

The follow-up for this is to add custom CEL probe to the CER API, which will necessitate these tests as we currently have no way of setting the custom probes in the bundle and carrying them into the CER.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-05T07:42:11Z

internal/operator-controller/controllers/clusterextensionrevision_controller.go

+	pvcBoundCEL   = `self.status.phase == "Bound"`
+	pvcBoundProbe probing.GroupKindSelector
+
 	// deplStaefulSetProbe probes Deployment, StatefulSet objects.


The comment for deplStatefulSetProbe is misspelled/inaccurate (deplStaefulSetProbe). This makes the identifier hard to search for and is inconsistent with the actual variable name. Update the comment to match deplStatefulSetProbe (and correct “Stateful”).

Suggested change

// deplStaefulSetProbe probes Deployment, StatefulSet objects.

// deplStatefulSetProbe probes Deployment, StatefulSet objects.

I didn't change this line, I can keep it in mind for a future PR though

test/e2e/features/revision.feature

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pedjak · 2026-03-05T15:29:37Z

test/e2e/features/revision.feature

+        annotations:
+          olm.operatorframework.io/service-account-name: olm-sa
+          olm.operatorframework.io/service-account-namespace: ${TEST_NAMESPACE}


are these annotations required for reconciliation to work?

yeah =/ this is a bit of a rough edge since we don't expose the service account configuration in the .spec. I think it's ok to leave it like this for now since we'll need to act on it once we have a decision on the OLM MVP and whether we want to keep the service account or not.

test/e2e/features/revision.feature

pedjak · 2026-03-05T15:38:31Z

test/e2e/features/revision.feature

+                volumeMode: Filesystem
+                local:
+                  path: /tmp/persistent-volume


this works under kind, does it work under openshift?

It does, I just tested it (aws). I can try a few other cluster types too just in case.

test/e2e/features/revision.feature

internal/operator-controller/controllers/clusterextensionrevision_controller.go

Adds readiness probing via CEL for namespaces and PVCs, to prevent subsequent phases from installing until their readiness checks have passed. Also adds e2e coverage via direct CER creation. Increased e2e timeout to 15m for experimental target. Signed-off-by: Daniel Franz <dfranz@redhat.com>

perdasilva · 2026-03-06T16:35:39Z

/approve

rashmigottipati

Changes look great to me!

/lgtm

openshift-ci · 2026-03-06T17:39:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings March 3, 2026 15:07

openshift-ci bot requested review from ankitathomas and bentito March 3, 2026 15:08

Copilot started reviewing on behalf of dtfranz March 3, 2026 15:10 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

dtfranz force-pushed the pvc-namespace-probes branch 2 times, most recently from d87dfaf to 6a9f311 Compare March 3, 2026 15:45

Copilot AI review requested due to automatic review settings March 3, 2026 15:45

dtfranz force-pushed the pvc-namespace-probes branch from 6a9f311 to ec5019e Compare March 3, 2026 15:47

Copilot AI reviewed Mar 3, 2026

View reviewed changes

test/e2e/steps/steps.go Outdated Show resolved Hide resolved

test/e2e/steps/steps.go Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of dtfranz March 3, 2026 16:09 View session

dtfranz force-pushed the pvc-namespace-probes branch 2 times, most recently from 493a1a7 to 1c7882b Compare March 4, 2026 09:31

Copilot AI review requested due to automatic review settings March 4, 2026 09:31

Copilot started reviewing on behalf of dtfranz March 4, 2026 09:31 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

test/e2e/features/revision.feature Outdated Show resolved Hide resolved

internal/operator-controller/controllers/clusterextensionrevision_controller.go Outdated Show resolved Hide resolved

test/e2e/steps/steps.go Show resolved Hide resolved

dtfranz force-pushed the pvc-namespace-probes branch from 1c7882b to 1f0a99f Compare March 4, 2026 10:21

pedjak reviewed Mar 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 5, 2026 07:36

dtfranz force-pushed the pvc-namespace-probes branch from 1f0a99f to f24055a Compare March 5, 2026 07:36

Copilot started reviewing on behalf of dtfranz March 5, 2026 07:36 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

dtfranz force-pushed the pvc-namespace-probes branch from f24055a to 944188b Compare March 5, 2026 09:11

pedjak reviewed Mar 5, 2026

View reviewed changes

test/e2e/features/revision.feature Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 5, 2026 12:42

dtfranz force-pushed the pvc-namespace-probes branch from 944188b to d73a46d Compare March 5, 2026 12:42

Copilot started reviewing on behalf of dtfranz March 5, 2026 12:42 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

pedjak reviewed Mar 5, 2026

View reviewed changes

perdasilva reviewed Mar 5, 2026

View reviewed changes

internal/operator-controller/controllers/clusterextensionrevision_controller.go Show resolved Hide resolved

dtfranz force-pushed the pvc-namespace-probes branch from d73a46d to be95970 Compare March 6, 2026 02:49

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026

rashmigottipati approved these changes Mar 6, 2026

View reviewed changes

openshift-ci bot assigned rashmigottipati Mar 6, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2026

	// deplStaefulSetProbe probes Deployment, StatefulSet objects.
	// deplStatefulSetProbe probes Deployment, StatefulSet objects.

Conversation

dtfranz commented Mar 3, 2026

Description

Reviewer Checklist

Uh oh!

netlify bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedjak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dtfranz commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Mar 3, 2026 •

edited

Loading

codecov bot commented Mar 3, 2026 •

edited

Loading