Skip to content

fix: typo in AgregatePriorityListConfigProvider name#3217

Open
csviri wants to merge 1 commit intooperator-framework:nextfrom
csviri:typo-metrics
Open

fix: typo in AgregatePriorityListConfigProvider name#3217
csviri wants to merge 1 commit intooperator-framework:nextfrom
csviri:typo-metrics

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Mar 10, 2026

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Copilot AI review requested due to automatic review settings March 10, 2026 17:35
@openshift-ci openshift-ci bot requested review from metacosm and xstefank March 10, 2026 17:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typo in the AggregatePriorityListConfigProvider class name and updates all in-repo references accordingly (tests, loader wiring, and documentation).

Changes:

  • Rename AgregatePriorityListConfigProviderAggregatePriorityListConfigProvider (class + constructor).
  • Update ConfigLoader to import/instantiate the corrected provider name.
  • Update tests and docs to reference the corrected provider name.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/provider/AggregatePriorityListConfigProvider.java Renames the public provider class and its constructor to fix the typo.
operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/ConfigLoader.java Updates import and default provider instantiation to use the corrected type.
operator-framework/src/test/java/io/javaoperatorsdk/operator/config/loader/provider/PriorityListConfigProviderTest.java Updates tests to instantiate the corrected provider type.
operator-framework/src/test/java/io/javaoperatorsdk/operator/config/loader/ConfigLoaderTest.java Fixes a javadoc reference to the corrected provider name.
docs/content/en/docs/documentation/configuration.md Updates documentation references and example code to the corrected provider name.
Comments suppressed due to low confidence (1)

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/provider/AggregatePriorityListConfigProvider.java:33

  • Renaming this public class/constructor is a source- and binary-incompatible change for downstream users that may already reference AgregatePriorityListConfigProvider. Consider keeping a deprecated compatibility shim (e.g., an AgregatePriorityListConfigProvider type that extends/delegates to AggregatePriorityListConfigProvider) for at least one release to avoid breaking existing code.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants