fix: typo in AgregatePriorityListConfigProvider name#3217
Open
csviri wants to merge 1 commit intooperator-framework:nextfrom
Open
fix: typo in AgregatePriorityListConfigProvider name#3217csviri wants to merge 1 commit intooperator-framework:nextfrom
csviri wants to merge 1 commit intooperator-framework:nextfrom
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a typo in the AggregatePriorityListConfigProvider class name and updates all in-repo references accordingly (tests, loader wiring, and documentation).
Changes:
- Rename
AgregatePriorityListConfigProvider→AggregatePriorityListConfigProvider(class + constructor). - Update
ConfigLoaderto import/instantiate the corrected provider name. - Update tests and docs to reference the corrected provider name.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/provider/AggregatePriorityListConfigProvider.java | Renames the public provider class and its constructor to fix the typo. |
| operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/ConfigLoader.java | Updates import and default provider instantiation to use the corrected type. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/config/loader/provider/PriorityListConfigProviderTest.java | Updates tests to instantiate the corrected provider type. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/config/loader/ConfigLoaderTest.java | Fixes a javadoc reference to the corrected provider name. |
| docs/content/en/docs/documentation/configuration.md | Updates documentation references and example code to the corrected provider name. |
Comments suppressed due to low confidence (1)
operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/provider/AggregatePriorityListConfigProvider.java:33
- Renaming this public class/constructor is a source- and binary-incompatible change for downstream users that may already reference
AgregatePriorityListConfigProvider. Consider keeping a deprecated compatibility shim (e.g., anAgregatePriorityListConfigProvidertype that extends/delegates toAggregatePriorityListConfigProvider) for at least one release to avoid breaking existing code.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com