Skip to content

🌱 Bump github.com/onsi/ginkgo/v2 from 2.33.0 to 2.34.0 - #574

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Bumps github.com/onsi/ginkgo/v2 from 2.33.0 to 2.34.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.34.0

Features

  • DeferOnFailure registers a callback that runs only when a spec fails - as soon as the failing node returns and before any teardown (JustAfterEach, AfterEach, AfterAll, DeferCleanup) - so it can capture the state teardown is about to destroy. It takes exactly what DeferCleanup takes and shares its scoping: called in BeforeEach/JustBeforeEach/It it covers the spec, in BeforeAll the ordered container, and in BeforeSuite the whole suite. It is also available on GinkgoT(); note that this adds a method to FullGinkgoTInterface, so hand-written implementations of that interface need to add it. See https://onsi.github.io/ginkgo/#capturing-failure-state-deferonfailure

Fixes

  • Progress reporters (AttachProgressReporter) are no longer called while Ginkgo holds an internal lock, so a reporter that calls CurrentSpecReport() or AddReportEntry() no longer stalls for 5 seconds and has its output dropped.
  • --sleep-on-failure now runs after any DeferOnFailure callbacks, also pauses when a spec times out, and no longer pauses if the suite has already been interrupted.

v2.33.1

Fixes

  • Add several missing fields to spec report JSON output.
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.34.0

Features

  • DeferOnFailure registers a callback that runs only when a spec fails - as soon as the failing node returns and before any teardown (JustAfterEach, AfterEach, AfterAll, DeferCleanup) - so it can capture the state teardown is about to destroy. It takes exactly what DeferCleanup takes and shares its scoping: called in BeforeEach/JustBeforeEach/It it covers the spec, in BeforeAll the ordered container, and in BeforeSuite the whole suite. It is also available on GinkgoT(); note that this adds a method to FullGinkgoTInterface, so hand-written implementations of that interface need to add it. See https://onsi.github.io/ginkgo/#capturing-failure-state-deferonfailure

Fixes

  • Progress reporters (AttachProgressReporter) are no longer called while Ginkgo holds an internal lock, so a reporter that calls CurrentSpecReport() or AddReportEntry() no longer stalls for 5 seconds and has its output dropped.
  • --sleep-on-failure now runs after any DeferOnFailure callbacks, also pauses when a spec times out, and no longer pauses if the suite has already been interrupted.

2.33.1

Fixes

  • Add several missing fields to spec report JSON output.
Commits
  • 7035669 v2.34.0
  • 6698926 docs: DeferOnFailure notes for library authors and pause-style callbacks
  • b66a63f Add parallel and JSON integration coverage for DeferOnFailure
  • 07edd04 Precompile the fixtures in the multi-suite timeout integration test
  • db1c4c8 Add DeferOnFailure
  • fba28c7 Query progress reporters without holding selectiveLock
  • 7ff96d7 v2.33.1
  • 699632a Precompile the fixture in the suite-timeout integration test (#1689)
  • 9e02cad ci: default the release bump so a mobile dispatch can't send it empty (#1688)
  • ef6a46c Update CHANGELOG.md
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Chores
    • Updated an internal testing dependency.

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.33.0 to 2.34.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.33.0...v2.34.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The github.com/onsi/ginkgo/v2 dependency in go.mod is upgraded from v2.33.0 to v2.34.0.

Changes: Ginkgo dependency update

Layer / File(s) Summary
Update Ginkgo version
go.mod
The declared Ginkgo v2 dependency version changes from v2.33.0 to v2.34.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to e46e1

The dependency update is mergeable after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the Ginkgo dependency upgrade and both versions.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

golangci-lint (2.15.0)

golangci-lint (2.15.0) skipped for .golangci.yml: configuration requires version: "2". Migrate older configurations using golangci-lint migrate and review the result; see https://golangci-lint.run/docs/product/migration-guide/.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 5a560ff0-c31f-44a0-ad3b-cc3eeac09780
Commits

Reviewing files that changed from the base of the PR and between 3722a95 and e46e15d.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 1

  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deps area/sdk dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant