Skip to content

WIP: Apply backpressure to add_item operations #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benoit74 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Apply backpressure to add_item operations #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/zim/test_zim_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,3 +973,33 @@ def test_config_indexing(tmp_path: pathlib.Path):
assert Creator(tmp_path / "_.zim", "").config_indexing(True, "bam")
assert Creator(tmp_path / "_.zim", "").config_indexing(False, "bam")
assert Creator(tmp_path / "_.zim", "").config_indexing(False)


def test_item_backpressure(tmp_path: pathlib.Path, html_file: pathlib.Path):
fpath = tmp_path / "test.zim"

class Store:
inflight_count = 0

def cb():
Store.inflight_count -= 1

with Creator(fpath, "").config_dev_metadata() as creator:
max_inflight = 0
for i in range(200):
while Store.inflight_count > 100:
time.sleep(0.01)
# adding GC collection to trigger finalization does not help
# gc.collect()
creator.add_item(
StaticItem(
path=f"{i}_{html_file.name}",
filepath=html_file,
mimetype="text/html",
),
callbacks=Callback(func=cb),
)
Store.inflight_count += 1
max_inflight = max(Store.inflight_count, max_inflight)

assert max_inflight < 1000
Loading