fix: stop scraper from finishing ZIM when bad exception arises

[lumpy72006]

fixes #54

Changes

• Wrapped the ZIM creation context manager in a try...except Exception: block inside generator.py.

• If an exception occurs, delete the incomplete ZIM file and
  bubble the exception to entrypoint and exit with code 1

• Added test_generate_zim_cleans_up_on_failure to tests/test_generator.py to ensure the file is deleted and the exception is propagated when get_db fails.

[benoit74]

This is not the correct way to fix the issue.

Creator object already has required primitive to indicate ZIM must not be created (finish).

Please have a look at logic around can_finish at https://github.com/openzim/mindtouch/blob/d1909c9b225afc92b44140a5bf9ff5087f6558ec/scraper/src/mindtouch2zim/processor.py#L287-L305 for instance.

[lumpy72006]

I didn't know the creator object had that, thank you. Let me know if this works

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.36%. Comparing base (3ddcae7) to head (0eb08cd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   92.28%   92.36%   +0.08%     
==========================================
  Files           4        4              
  Lines         376      380       +4     
  Branches       37       37              
==========================================
+ Hits          347      351       +4     
  Misses         25       25              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[benoit74]

LGTM, please add an entry to the CHANGELOG.md and squash all your commits into a single one on top of main branch.

[lumpy72006]

Done

[benoit74]

LGTM