Skip to content

Conversation

@danielfdickinson
Copy link
Contributor

@danielfdickinson danielfdickinson commented Dec 26, 2025

📦 Package Details

Maintainer: @feckert

Description:

This rework was unneeded, rather the fix in #28174 is required to resolve missing HTTP_AUTH support.

The original issue in #27526 (unable to update OVH DynHost IP address) was wrongly attributed to a change on the OVH API. As discussed in #28172 the API continues to work for 24.10.5 systems, as well as users using wget-ssl.

The changes in #27561 and the followup fix #27694 add unnecessary dependencies which are heavier than the actually needed minimum.

Therefore return the OVH provider to the previous state, and let #28174 resolve the issue.

See also #28172


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT (32402-501e54b6c2)
  • OpenWrt Target/Subtarget: bcm27xx/bcm2712
  • OpenWrt Device: rpi-5

(with #28174 also applied)

  1. In global settings for ddns-scripts, set force curl
  2. Enabled a DDNS host updater with OVH
  3. Started the updater and observed a successful update
  4. Checked the logs and verified a successful cURL run with the original OVH provider (username:password - style).
  5. Observed the update occured correctly

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

N/A

This rework was unneeded, rather the fix in
openwrt#28174 is required to resolve
missing HTTP_AUTH support.

The original issue in openwrt#27526
(unable to update OVH DynHost IP address) was wrongly attributed to a
change on the OVH API. As discussed in
openwrt#28172 the API continues to
work for 24.10.5 system, as well as users using wget-ssl.

The changes in openwrt#27561 and
the followup fix openwrt#27694 add
unnecessary dependencies which are heavier than the actually needed
minimum.

Therefore return the OVH provider to the previous state, and let
openwrt#28174 resolved the issue.

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
@danielfdickinson danielfdickinson marked this pull request as ready for review December 26, 2025 07:16
@thomas-maurice
Copy link

Also the updater script is completely broken, at a minimum we need to rewrite the encoding of the credentials with

http_basic_encoding() {
        local user="$1"
        local password="$2"
       # added the `tr -d` to remove any carriage returns added by openssl
        echo -n "${user}:${password}" | openssl base64 -in /dev/stdin | tr -d "\n"
}

as the current version adds a bunch of unwanted \n in the token which makes the curl call completely fail

@mundschenk-at
Copy link

Also the updater script is completely broken, at a minimum we need to rewrite the encoding of the credentials with

http_basic_encoding() {
        local user="$1"
        local password="$2"
       # added the `tr -d` to remove any carriage returns added by openssl
        echo -n "${user}:${password}" | openssl base64 -in /dev/stdin | tr -d "\n"
}

as the current version adds a bunch of unwanted \n in the token which makes the curl call completely fail

-A should prevent base64 from adding newlines.

@danielfdickinson
Copy link
Contributor Author

To clarify @thomas-maurice @mundschenk-at : the proposed PR would remove the updater script entirely and switch back to template based approach that was used before any of the rework. The switch to an updater script was unnecessary and done based on a mistaken understanding of the cause of the authentication issue. The proper fix has already been merged with #28174.

@feckert feckert merged commit 01ac296 into openwrt:master Jan 7, 2026
12 checks passed
@feckert
Copy link
Member

feckert commented Jan 7, 2026

Thanks merged!

@feckert
Copy link
Member

feckert commented Jan 7, 2026

@danielfdickinson Can you please also create a PR for the next stable release branch 25.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants