Open
Conversation
increment cnt, otherwise cnt is always zero and query always has zero source's Signed-off-by: Neil Kettle <neil@digit-labs.org>
Signed-off-by: Neil Kettle <neil@digit-labs.org>
Since VIFF_USE_IFINDEX is set, at least in the first setsockout(), you meant to use a non-zero value for vifc_lcl_ifindex? Signed-off-by: Neil Kettle <neil@digit-labs.org>
Dealing with IPv6 here, better to avoid the truncation and use INET6_ADDRSTRLEN? Signed-off-by: Neil Kettle <neil@digit-labs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bugs noted when reviewing some of the code, nothing important, well, maybe 65559b2 is leading to un-noticed breakage.