feat: check PKG_RELEASE bumps#120
Open
aparcar wants to merge 1 commit into
Open
Conversation
Changing the Makefile, patches or content without bumping the PKG_RELEASE causes different binaries with the same version/release. Avoid this by failing the CI in those cases. Signed-off-by: Paul Spooren <mail@aparcar.org>
Member
|
A bit of a rant/complaint, but this kinda reminds me that we've already been through this. RIP AUTORELEASE. :( |
BKPepe
reviewed
Jun 30, 2026
| # Packages using AUTORELEASE get their release bumped automatically from | ||
| # the git history, so they are exempt. | ||
| if grep -q 'AUTORELEASE' "$REPO_DIR/$makefile" 2>/dev/null; then | ||
| status_skip 'uses AUTORELEASE' |
Member
There was a problem hiding this comment.
Autorelease is already deprecated and should no longer be used, as all the jobs across OpenWrt repositories that warned about it have been disabled. So, this one is no longer needed, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the Makefile, patches or content without bumping the PKG_RELEASE causes different binaries with the same version/release. Avoid this by failing the CI in those cases.