[cleanup] Remove deprecated code marked for 1.2.0 release #1182
+2
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viscous106
force-pushed
the
cleanup-deprecated-1-2-0
branch
2 times, most recently
from
53d8044 to
ca459d1
Compare
Viscous106
force-pushed
the
cleanup-deprecated-1-2-0
branch
from
ca459d1 to
27f9893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes multiple instances of deprecated code that were marked for removal in release 1.2.0 (or earlier). This cleans up technical debt in the config, tasks, and controller views.
Changes
config.py): Removed the deprecatedget_cached_argscompatibility wrapper.tasks.py): Removed the deprecatedinvalidate_device_checksum_view_cachetask.views.py): Removed legacy support forstatus="running"inDeviceReportStatusView. The modernstatus="applied"logic is preserved.test_controller.py): Removedtest_device_report_status_runningwhich tested the deprecated "running" status.Verification
python tests/manage.py test openwisp_controller.configtest_device_report_status_appliedstill passes and the controller handles status updates correctly.