-
-
Notifications
You must be signed in to change notification settings - Fork 240
[feature] New ws endpoint for all all Location broadcast #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gsoc25-map
Are you sure you want to change the base?
Conversation
| if ( | ||
| result | ||
| and not user.is_superuser | ||
| and not user.is_manager(location.organization) | ||
| ): | ||
| return False | ||
| return result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if ( | |
| result | |
| and not user.is_superuser | |
| and not user.is_manager(location.organization) | |
| ): | |
| return False | |
| return result | |
| return result and (user.is_superuser or user.is_manager(location.organization)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make these changes, but then in LocationBroadcast above, we have the same logic written in 2 different ways!
We can change both or keep it as it is
Let me know which is better
61709be to
f843054
Compare
Implemented a new websocket endpoint 'location/all/' with updated user permission from base clases from django-loci. Fixes #1157
f843054 to
75476f6
Compare
d6a09ed to
ade9399
Compare
ade9399 to
9697b8b
Compare
Updates
Build on top of openwisp/django-loci#193 |
0e91107 to
f0f5305
Compare
Checklist
Reference to Existing Issue
Closes #1157.
Description of Changes
location/allfrom base django-loci clases with updated user permissions.Screen Recording
Screencast.from.2025-11-13.02-20-06.webm