Add error handling in the pg problem editor#3046
Open
pstaabp wants to merge 1 commit into
Open
Conversation
pstaabp
force-pushed
the
pgml-convert-pgeditor
branch
from
1556e15 to
5659ea7
Compare
pstaabp
force-pushed
the
pgml-convert-pgeditor
branch
from
5659ea7 to
9085b25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds error handling for the PGML converter to the PGProblemEditor. This mimics the pg tidy interface and code.
If there is an error in parsing the PG problem--currently only the loadMacros command will throw an error--then the error is shown in the right pane of the PG problem editor. Upon fixing the error and rerunning the "Convert to PGML" in the "Code Maintenance" table, the code is updated and pre-rendered. Note, previously, the code was not rerendered after code conversion.
Also, openwebwork/pg#1425 is needed to test this.