Skip to content

typos identified by github.com/crate-ci/typos#3044

Open
Alex-Jordan wants to merge 1 commit into
openwebwork:WeBWorK-2.21from
Alex-Jordan:typos
Open

typos identified by github.com/crate-ci/typos#3044
Alex-Jordan wants to merge 1 commit into
openwebwork:WeBWorK-2.21from
Alex-Jordan:typos

Conversation

@Alex-Jordan

Copy link
Copy Markdown
Contributor

These are typos in lib, but not in lib/WeBWorK/.

The misnaming of ResourceIri as ResourseIri was consistent. Someone who knows Caliper should weigh in about this, if the package is used outside of this code. @andrew-gardener, does changing this typo matter?

I have not thought hard about the typo in lib/WebworkWebservice/RenderProblem.pm. If that code gets used, certainly it is broken with the typo in place.

@drgrice1

drgrice1 commented Jul 8, 2026

Copy link
Copy Markdown
Member

I do not know Caliper particularly well. However, I do know that if the typo is fixed consistently, it will not matter, and the code will still work.

@drgrice1

drgrice1 commented Jul 8, 2026

Copy link
Copy Markdown
Member

In fact, I am not entirely certain that the code works with that typo since the file is named ResourceIri.pm without the typo. The Caliper code is highly suspect and unmaintained, and unless someone steps up to maintain it, it should be removed.

@Alex-Jordan

Copy link
Copy Markdown
Contributor Author

I added more to this. I won't add any more after this though. Any more will be in separate PRs. This now includes lib/WeBWorK/, but not lib/WeBWorK/ContentGenerator/, lib/WeBWorK/Localize/, or lib/WeBWorK/Utuils/. Those each have have many more typos.

One place that should get extra inspection is the changes to lib/WeBWorK/Authen/Saml2.pm.

@drgrice1

drgrice1 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Is there a spell checker for GitHub conversations? lib/WeBWorK/Utuils

@Alex-Jordan

Copy link
Copy Markdown
Contributor Author

Haha, yeah I saw that after I posted and left it for fun.

lib/WeBWorK/Localize/ just has typos that are derived from other typos. So I'm not going in there. And it turns out lib/WeBWorK/Utils/ has few enough typos that I will add it here.

I'll save lib/WeBWorK/ContentGenerator/ fir another day.

@drgrice1 drgrice1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and some of the typos were causing issues.

The typo in lib/WeBWorK/Authen/Saml2.pm is a local typo, and fixing it won't break anything (or fix anything other than making the spelling correct).

The typo in lib/WeBWorK/ConfigValues.pm was preventing the LTI{v1p3}{PlatformID} variable from working in the LTI tab. So this is a bug fix.

The typo in lib/WebworkWebservice/RenderProblem.pm was clearly preventing the preview button from working as intended. Although, some might argue that the intended functionality of showing answer evaluator messages for an answer preview is not desirable. But that is another debate.

@drgrice1

drgrice1 commented Jul 8, 2026

Copy link
Copy Markdown
Member

I just noted that there were two typos in lib/WeBWorK/Saml2.pm. The $ceritificateOnly typo was the local one I referred to. The other typo certainly needs to be fixed, but would only cause an "uninitialized string" warning when debugging is enabled, and prevent the debugging message from being as useful as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants