Creation of sample problems that use the StatisticalPlots macro. by pstaabp · Pull Request #1449 · openwebwork/pg

pstaabp · 2026-06-25T12:26:06Z

This adds some sample problems that use the StatisticalPlots.pl macro.

Alex-Jordan · 2026-06-25T16:51:53Z

+});
+
+$alt_textB =
+    "A horizontal box plot with the box betwen $q1B and $q3B and vertical "


s/betwen/between/g

I installed github.com/crate-ci/typos and it seems pretty good at catching real typos. Maybe we can integrate it into workflows. It does need manual oversight for false positives, and for when it is unsure how to correct a typo.

drgrice1

This needs some changes.

Make sure to use perltidy-pg on the added problems. All of them are showing changes when that is done.

drgrice1 · 2026-07-08T00:28:05Z

 #:% section = preamble
-#: Make sure that PODLINK('plots.pl') is loaded.
+#: This produces a scatter plot with PODLINK('plots.pl').  A version of this 
+#: with the PODLINK('StatisticalPlots.pl') is available in 


This should be

Suggested change

#: with the PODLINK('StatisticalPlots.pl') is available in

#: with PODLINK('StatisticalPlots.pl') is available in

drgrice1 · 2026-07-08T00:37:52Z

+#: Use `xtick_labels` to customize the tick labels and the resulting hashref
+#: is a mapping from the old tick labels to the new labels.


This should be

Suggested change

#: Use `xtick_labels` to customize the tick labels and the resulting hashref

#: is a mapping from the old tick labels to the new labels.

#: Use `xtick_labels` to customize the tick labels. The hash reference value

#: is a mapping from tick positions to new labels.

Please do not use hashref or arrayref anymore in documentation. They are not words.

This is not a "resulting" hash reference, it is the value set for the xtick_labels option. It does not "result" from anything. It is given.

The mapping is not from the old tick labels, but from the tick positions.

drgrice1 · 2026-07-08T00:40:55Z

+#: The bars are added with the `add_barplot` method with the xdata and ydata.
+#: The `bar_width` give a relative width of the bar.  If this option is 1 
+#: there is no gap between bars.  
+#: See PODLINK('StatisticalPlots.pl') for other options to this method.
+#:


This should be

Suggested change

#: The bars are added with the `add_barplot` method with the xdata and ydata.

#: The `bar_width` give a relative width of the bar. If this option is 1

#: there is no gap between bars.

#: See PODLINK('StatisticalPlots.pl') for other options to this method.

#:

#: The bars are added with the `add_barplot` method passing the x and y data

#: values. The `bar_width` gives the relative width of the bar. If this option

#: is 1, then there is no gap between bars. See PODLINK('StatisticalPlots.pl')

#: for other options to this method.

#:

drgrice1 · 2026-07-08T01:37:09Z

+$num_students = 0;
+$num_students += $_ for @grades;
+
+$perA = Real($grades[0] / $num_students);


This should be

Suggested change

$perA = Real($grades[0] / $num_students);

$perA = Compute($grades[0] / $num_students);

Your question asks for a percent. If you use the Percent context, but call Real it does not create a percent. It creates a real. Using Compute in the Percent context creates a percent in the way that you describe in the documentation below.

drgrice1 · 2026-07-08T01:43:46Z

+#: the number of minor ticks between each tick.
+#:
+#: The box plot is created with the `add_boxplot` method in which the data is the
+#: first argument (it is an array ref, which is why the `~~` is needed).  The


Please spell out "reference".

drgrice1 · 2026-07-08T02:20:31Z

+    aria_label  => 'Linear Regression'
+);
+$plot->add_scatterplot(
+    @data,


This should be

Suggested change

@data,

~~@data,

drgrice1 · 2026-07-08T02:22:30Z

+#: function of PODLINK('PGstatisticsmacros.pl').  Note: the x and y data
+#: needs to be array references and the 2nd and 3rd lines extract the
+#: components.


This should be

Suggested change

#: function of PODLINK('PGstatisticsmacros.pl'). Note: the x and y data

#: needs to be array references and the 2nd and 3rd lines extract the

#: components.

#: function of PODLINK('PGstatisticsmacros.pl'). Note that the x and y data values

#: need to be in array references, and the 2nd and 3rd lines extract the

#: components.

drgrice1 · 2026-07-08T02:25:18Z

+#: For the plot, first set up the `Plot` with a plotting window that will
+#: capture the data. The `add_dataset` method adds the data to the plot
+#: with circles and color blue.


Please change this to something like

Suggested change

#: For the plot, first set up the `Plot` with a plotting window that will

#: capture the data. The `add_dataset` method adds the data to the plot

#: with circles and color blue.

#: Set up the `StatPlot` with a plotting window that will

#: contain the data. The `add_dataset` method adds the data to the plot

#: with circle marks that are colored blue.

drgrice1 · 2026-07-08T02:30:34Z

+#: The data is formatted by putting the array data in a nice format using both
+#: join (which joins an array separated by ', ') and map (which creates a new
+#: array that formats as (x1, y1)).  The [@ @] is used to run perl.
+#:
+#: The `[! !]{}{}` is a PGML format for inserting an image.


Please rework this section. It reads rather poorly. For example, the first sentence says "the data is formatted ... in a nice format". That is really bad. Also, make sure that all of the things such as ', ', (x1, y1), and [@ @] are properly set out using markdown.

I realize you copied this from the ScatterPlot.pg problem. That problem should also be fixed.

drgrice1 · 2026-07-08T02:32:05Z

+## DBsection(PGML tutorial 2015)
+## Date(06/01/2026)
+## Institution(Boise State University)
+## Author(Jaimos Skriletz)


Is "Jaimos Skriletz" really the author of this problem? I think @somiaj would make sure the problem actually worked before submitting it in a pull request.

Creation of sample problems using StatisticalPlots macro.

f398a36

Alex-Jordan reviewed Jun 25, 2026

View reviewed changes

fix typo

83cbb83

drgrice1 reviewed Jul 8, 2026

View reviewed changes

	#: with the PODLINK('StatisticalPlots.pl') is available in
	#: with PODLINK('StatisticalPlots.pl') is available in

		#: Use `xtick_labels` to customize the tick labels and the resulting hashref
		#: is a mapping from the old tick labels to the new labels.

	$perA = Real($grades[0] / $num_students);
	$perA = Compute($grades[0] / $num_students);

Uh oh!

Uh oh!

Conversation

pstaabp commented Jun 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drgrice1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants