Clean up how the feedback reveal button works. #1360
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of automatically hiding the reveal button every time the feedback popover is opened after the reveal button has been used for the first time, completely remove the reveal button from the popover content, and remove the `d-none` class from the `div` containing the correct answer. Thus on subsequent loads the correct answer is shown cleanly. Currently you can see the reveal button for a brief instant before it is removed.
drgrice1
force-pushed
the
feedback-reveal-correct-improvements
branch
from
dd0768f to
6a4df5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of automatically hiding the reveal button every time the feedback popover is opened after the reveal button has been used for the first time, completely remove the reveal button from the popover content, and remove the
d-noneclass from thedivcontaining the correct answer. Thus on subsequent loads the correct answer is shown cleanly. Currently you can see the reveal button for a brief instant before it is removed.