Skip to content

fix test for onyx parser #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dtrawins wants to merge 1 commit into
base: muse_onyx
Choose a base branch
from
+6 −13
Draft

fix test for onyx parser #4443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions src/test/llm/chat_template_and_parser_onyx_roundtrip_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,19 +147,12 @@ TEST_F(OnyxChatTemplateAndParserRoundtripTest, ToolResultFedBack_ModelEmitsFinal
// Assistant tool-call history uses the recipient/content path (not `tool_calls`), which the
// new template still renders via the plain "to=<recipient><|message|>...<|eom|>" envelope.
EXPECT_NE(prompt.find(R"(<|start|>assistant to=functions.get_weather<|message|>{"city": "SF"}<|eom|>)"), std::string::npos) << prompt;
// NOTE (verified against the new template's actual minja render): OpenVINO GenAI STILL
// rewrites role="tool" into a role="user" message wrapping a "tool_response" JSON object
// (caps.supportsToolCalls == false), even though the new template DOES read `tools`/render
// tool defs -- so Onyx's own `elif role == 'tool'` template branch remains DEAD CODE on the
// minja path. What changed vs the previous drop: the wrapper no longer carries a "tool"
// field (only "content"). The tool output content appears with backslash-escaped quotes
// inside that JSON string, e.g.:
// <|start|>user<|message|>{
// "tool_response": {
// "content": "<tool_output name=\"functions.get_weather\">{\"temp\": 65}</tool_output>"
// }<|eot|>
EXPECT_NE(prompt.find(R"("tool_response")"), std::string::npos) << prompt;
EXPECT_NE(prompt.find(R"(<tool_output name=\"functions.get_weather\">{\"temp\": 65}</tool_output>)"), std::string::npos) << prompt;
// NOTE: the Onyx template's `elif role == 'tool'` branch IS active on the minja path
// (caps.supportsToolCalls == true for this template), so the tool response is rendered as:
// <|start|>tool functions.get_weather<|message|><tool_output name="functions.get_weather">
// ...content...<|eot|>
EXPECT_NE(prompt.find(R"(<|start|>tool functions.get_weather<|message|>)"), std::string::npos) << prompt;
EXPECT_NE(prompt.find(R"({"temp": 65})"), std::string::npos) << prompt;

std::string modelContinuation = R"( to=user<|message|>It's 65F in SF.<|eot|>)";
ParsedOutput parsedOutput = parseModelContinuation(modelContinuation);
Expand Down