Skip to content

update_groovy_doc_on_commit - #4435

Open
ngrozae wants to merge 8 commits into
mainfrom
update_groovy_doc_on_commit
Open

update_groovy_doc_on_commit#4435
ngrozae wants to merge 8 commits into
mainfrom
update_groovy_doc_on_commit

Conversation

@ngrozae

@ngrozae ngrozae commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI lite review requested due to automatic review settings August 6, 2026 10:30
@ngrozae
ngrozae force-pushed the update_groovy_doc_on_commit branch from d1d65ce to 4cb3677 Compare August 6, 2026 10:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the on-commit Jenkins pipeline logic for selecting documentation tests, and adds a small snippet to the project README.

Changes:

  • Adjusts how the list of changed documentation files is converted into a pytest -k filter in ci/build_test_OnCommit.groovy (Linux + Windows doc-test stages).
  • Adds a short console example snippet to README.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
README.md Adds a console snippet under the Contact section.
ci/build_test_OnCommit.groovy Modifies construction of the pytest -k expression used to select documentation tests on Linux/Windows.
Suppressed comments (1)

ci/build_test_OnCommit.groovy:406

  • Same issue as the Linux stage: prefixing each entry with - alters the pytest -k filter expression and can make it syntactically invalid or prevent any documentation tests from being selected. Use the unmodified list joined with or, and (if needed) create a separate formatted string for human-readable output.
                      def test_doc_files_str = test_doc_files_windows.split('\n').collect { '-' + it }.join(' or ')

Comment thread ci/build_test_OnCommit.groovy Outdated
Comment thread README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (3)

ci/build_test_OnCommit.groovy:343

  • test_doc_files_linux is populated with plain .md paths (e.g., from check_md_code_changes.sh or the commit override), but this code prepends an extra - to each entry. That changes the filter terms away from the actual paths and can prevent selecting the intended documentation tests.
                      def test_doc_files_str = test_doc_files_linux.split('\n').collect { '"' + '-' + it + '"' }.join(' or ')

ci/build_test_OnCommit.groovy:406

  • test_doc_files_windows is populated with plain .md paths, but this code prepends an extra - to each entry. That changes the filter terms away from the actual paths and can prevent selecting the intended documentation tests.
                      def test_doc_files_str = test_doc_files_windows.split('\n').collect { "'" + '-' + it + "'" }.join(' or ')

README.md:84

  • The README uses the non-standard "Github" capitalization; project documentation should use "GitHub".
If you have a question, a feature request, or a bug report, feel free to submit a Github issue.


```console
mkdir test

@ngrozae
ngrozae force-pushed the update_groovy_doc_on_commit branch from 160fa12 to 4de70b2 Compare August 6, 2026 13:11
@ngrozae
ngrozae force-pushed the update_groovy_doc_on_commit branch from 550d3c7 to 87daf5a Compare August 7, 2026 11:55
@ngrozae
ngrozae force-pushed the update_groovy_doc_on_commit branch from 87daf5a to e644d07 Compare August 7, 2026 12:01
@ngrozae
ngrozae force-pushed the update_groovy_doc_on_commit branch from 31c9f93 to 71e482d Compare August 7, 2026 13:40
@ngrozae
ngrozae force-pushed the update_groovy_doc_on_commit branch 2 times, most recently from c8cd375 to 2c8fe01 Compare August 11, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants