update_groovy_doc_on_commit - #4435
Open
ngrozae wants to merge 8 commits into
Open
Conversation
ngrozae
force-pushed
the
update_groovy_doc_on_commit
branch
from
August 6, 2026 10:31
d1d65ce to
4cb3677
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the on-commit Jenkins pipeline logic for selecting documentation tests, and adds a small snippet to the project README.
Changes:
- Adjusts how the list of changed documentation files is converted into a
pytest -kfilter inci/build_test_OnCommit.groovy(Linux + Windows doc-test stages). - Adds a short console example snippet to
README.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adds a console snippet under the Contact section. |
| ci/build_test_OnCommit.groovy | Modifies construction of the pytest -k expression used to select documentation tests on Linux/Windows. |
Suppressed comments (1)
ci/build_test_OnCommit.groovy:406
- Same issue as the Linux stage: prefixing each entry with
-alters the pytest-kfilter expression and can make it syntactically invalid or prevent any documentation tests from being selected. Use the unmodified list joined withor, and (if needed) create a separate formatted string for human-readable output.
def test_doc_files_str = test_doc_files_windows.split('\n').collect { '-' + it }.join(' or ')
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (3)
ci/build_test_OnCommit.groovy:343
test_doc_files_linuxis populated with plain.mdpaths (e.g., fromcheck_md_code_changes.shor the commit override), but this code prepends an extra-to each entry. That changes the filter terms away from the actual paths and can prevent selecting the intended documentation tests.
def test_doc_files_str = test_doc_files_linux.split('\n').collect { '"' + '-' + it + '"' }.join(' or ')
ci/build_test_OnCommit.groovy:406
test_doc_files_windowsis populated with plain.mdpaths, but this code prepends an extra-to each entry. That changes the filter terms away from the actual paths and can prevent selecting the intended documentation tests.
def test_doc_files_str = test_doc_files_windows.split('\n').collect { "'" + '-' + it + "'" }.join(' or ')
README.md:84
- The README uses the non-standard "Github" capitalization; project documentation should use "GitHub".
If you have a question, a feature request, or a bug report, feel free to submit a Github issue.
```console
mkdir test
ngrozae
force-pushed
the
update_groovy_doc_on_commit
branch
from
August 6, 2026 13:11
160fa12 to
4de70b2
Compare
pgladkows
approved these changes
Aug 6, 2026
ngrozae
force-pushed
the
update_groovy_doc_on_commit
branch
from
August 7, 2026 11:55
550d3c7 to
87daf5a
Compare
ngrozae
force-pushed
the
update_groovy_doc_on_commit
branch
from
August 7, 2026 12:01
87daf5a to
e644d07
Compare
ngrozae
force-pushed
the
update_groovy_doc_on_commit
branch
from
August 7, 2026 13:40
31c9f93 to
71e482d
Compare
…recognition/python/README.md]
ngrozae
force-pushed
the
update_groovy_doc_on_commit
branch
2 times, most recently
from
August 11, 2026 13:02
c8cd375 to
2c8fe01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``