gcc header fixes for Fedora 44 - #4425
Open
stevegrubb wants to merge 2 commits into
Open
Conversation
customloaderinterface.hpp uses uint8_t in its public method signatures but does not include the header that declares it. The header therefore compiles only when another include happens to provide the fixed-width integer definitions, and fails with current GCC when compiled independently. Include <cstdint> directly so the public interface is self-contained. This is an include-only correction with no ABI or behavior change.
session_id.hpp aliases uint32_t without including <cstdint>. This relies on a transitive include and fails when the header is compiled with an include order that does not provide the fixed-width integer declarations. Include <cstdint> directly so the session ID header owns its dependency. The alias and its ABI remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has 2 commits that fix an include error when compiling with gcc-16 on Fedora 44.
and
dags: include cstdint in session_id.hpp