Clean rate limits for hotkey/coldkey swaps

[evgeny-s]

Description

This PR cleans rate limits for:

• hotkey swap
• coldkey swap

Related Issue(s)

• Closes #[issue number]

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: established write-permission contributor, no Gittensor allowlist hit found, branch chore/clean-rate-limits -> devnet-ready.

Static analysis only. Reviewed the full 4-file diff: it removes generic LastTxBlock rate-limit checks/writes from hotkey/coldkey swap paths, keeps the subnet-specific LastHotkeySwapOnNetuid interval gate, and does not touch .github/, dependencies, build scripts, Cargo.lock, or review prompt files.

Findings

No findings.

Conclusion

No malicious code or security vulnerability found in the changed lines. The removed generic limiter appears scoped to the intended swap cleanup while existing ownership checks, swap costs, and subnet-specific swap interval checks remain in place.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Established write-permission contributor; no Gittensor allowlist hit found, treated as UNKNOWN for incentive calibration.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

Reviewed the 4-file runtime pallet diff. The change removes the generic TxRateLimit / LastTxBlock gate from hotkey and coldkey swap paths while preserving the subnet-specific LastHotkeySwapOnNetuid interval gate for subnet-scoped hotkey swaps. No duplicate-work concern: the overlapping PRs are unrelated governance/doc cleanup work.

No auto-fixes were applied. The PR touches pallets/, but the devnet runtime-version endpoint was not resolvable from this sandbox, so I could not confirm whether the devnet-ready spec-version check would require a bump. Local spec_version is 417.

Findings

No findings.

Conclusion

The implementation matches the stated cleanup: removed generic rate-limit reads/writes are no longer referenced by live swap gates, ownership/cost checks remain intact, and the updated tests cover the intended same-block hotkey swap behavior. I found no blocking domain issues.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍