refactor: replace RocksDbWeight with ParityDbWeight #2321
Closed
+80
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since subtensor uses ParityDB as the database backend, this change updates all weight references from RocksDbWeight to ParityDbWeight for consistency. Updated files: - runtime/src/lib.rs: DbWeight type - .maintain/frame-weight-template.hbs: benchmark template - pallets/*/src/weights.rs: pallet weight implementations - */mock.rs: test mocks Closes opentensor#2131
Author
|
@juniuszhou would you review this PR? |
Contributor
|
Author
|
Closing as duplicate - PR #2234 already addresses this issue. Thanks @open-junius for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RocksDbWeighttoParityDbWeightfor consistencyChanges
runtime/src/lib.rs: ChangedDbWeighttype fromRocksDbWeighttoParityDbWeight.maintain/frame-weight-template.hbs: Updated benchmark template to generateParityDbWeightreferencespallets/*/src/weights.rs: Updated all pallet weight implementations*/mock.rs: Updated test mocksCloses #2131
Test plan
cargo check --libpasses