Skip to content

openflow: fix multi-part reply and drain pending msgs - #54

Merged
aharivel merged 1 commit into
openstack-k8s-operators:18.0-fr6from
abhiramnarayana:backport/osprh-32382-fr6
Aug 31, 2026
Merged

openflow: fix multi-part reply and drain pending msgs#54
aharivel merged 1 commit into
openstack-k8s-operators:18.0-fr6from
abhiramnarayana:backport/osprh-32382-fr6

Conversation

@abhiramnarayana

Copy link
Copy Markdown
Contributor

Fix 'Broken pipe' errors in ovs-vswitchd.log caused by the exporter closing OpenFlow connections prematurely.

  • Add drainPendingMessages() helper to discard pending OVS messages
  • Modify getFlowStats() to loop until OFPSF_REPLY_MORE is unset
  • Add drain call to both getFlowStats() and GetAggregateStats()
  • Add unit tests for multi-part handling and drain functionality

Closes: OSPRH-32382

(cherry picked from commit 38c64db)

Fix 'Broken pipe' errors in ovs-vswitchd.log caused by the exporter
closing OpenFlow connections prematurely.

- Add drainPendingMessages() helper to discard pending OVS messages
- Modify getFlowStats() to loop until OFPSF_REPLY_MORE is unset
- Add drain call to both getFlowStats() and GetAggregateStats()
- Add unit tests for multi-part handling and drain functionality

Closes: OSPRH-32382
Signed-off-by: Abhiram R N <abhiramrn@gmail.com>
(cherry picked from commit 38c64db)
Signed-off-by: Abhiram R N <abhiramrn@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ff45f725-f68e-433d-8227-86becbdf6494

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aharivel
aharivel merged commit 5b696ae into openstack-k8s-operators:18.0-fr6 Aug 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants