Conversation
npajkovsky
approved these changes
Jan 27, 2026
| return; | ||
| } | ||
|
|
||
| counts[num]++; |
There was a problem hiding this comment.
nit: It's better to have size_t count locally, and update it after the test.
Contributor
Author
There was a problem hiding this comment.
Why is it better to do it like that?
There was a problem hiding this comment.
The local counter has less overhead than accessing a global array each iteration.
Member
There was a problem hiding this comment.
Why is it better to do it like that?
To avoid constant cacheline invalidation with constant writes by different cores.
nhorman
approved these changes
Jan 27, 2026
nhorman
pushed a commit
that referenced
this pull request
Jan 29, 2026
Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Thu Jan 29 16:42:18 2026 (Merged from #71)
Contributor
|
merged to main, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CLI tool
evp_macthat computes an HMAC of random data using SHA-256 digest.Runs for 5 seconds and prints the average execution time per encryption.
Fixes openssl/project#1837
Features
evp_shared(default): Use EVP API and allow shared data between computationsevp_isolated: Use EVP API and don't allow shared data between computationsdeprecated_shared: Use legacy API and allow shared data between computationsdeprecated_isolated: Use legacy API and don't allow shared data between computations-t)TODO: Since freeze functionality hasn't been properly added yet (see openssl/project#1832 & openssl/openssl#29433), support for freezing the context store has not been added yet.
Usage
Findings
Initial results showed that
evp_isolatedmode generally runs about 30x slower thanevp_sharedmode.