Skip to content

fix: remove duplicate pnpm version causing build-deploy failure - #87

Merged
sunshineg merged 2 commits into
mainfrom
copilot/fix-build-deploy-job
Aug 19, 2026
Merged

fix: remove duplicate pnpm version causing build-deploy failure#87
sunshineg merged 2 commits into
mainfrom
copilot/fix-build-deploy-job

Conversation

Copilot AI commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

pnpm/action-setup@v4 now errors when version is specified in the workflow and packageManager is set in package.json, since both pins must match exactly.

Changes

  • .github/workflows/gh-pages.yml: Remove version: 9 from the pnpm/action-setup step — package.json already declares "packageManager": "pnpm@9.15.0", which the action reads automatically.
# Before
- uses: pnpm/action-setup@v4
  with:
    version: 9  # conflicts with packageManager field in package.json

# After
- uses: pnpm/action-setup@v4  # uses pnpm@9.15.0 from package.json

Co-authored-by: sunshineg <1147886+sunshineg@users.noreply.github.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026

Copy link
Copy Markdown

Deploying opensourcewin-github-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: e9385cb
Status: ✅  Deploy successful!
Preview URL: https://57b70d1e.opensourcewin-github-io.pages.dev
Branch Preview URL: https://copilot-fix-build-deploy-job.opensourcewin-github-io.pages.dev

View logs

Copilot AI changed the title [WIP] Fix failing GitHub Actions job build-deploy fix: remove duplicate pnpm version causing build-deploy failure Aug 19, 2026
Copilot AI requested a review from sunshineg August 19, 2026 18:28
@sunshineg
sunshineg requested a lite review from Copilot August 19, 2026 18:29
@sunshineg
sunshineg marked this pull request as ready for review August 19, 2026 18:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an explicit pnpm version pin in the GitHub Pages deployment workflow to avoid pnpm/action-setup@v4 failing when a packageManager version is already declared in package.json.

Changes:

  • Removed the with: version: 9 configuration from the pnpm/action-setup@v4 step in the GitHub Pages workflow.
  • Relies on the repository’s packageManager: "pnpm@9.15.0" declaration for consistent pnpm resolution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sunshineg
sunshineg merged commit ad8036e into main Aug 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants