Automated - Update config ./config/openshift.yaml #3206
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
You can disable this status message by setting the WalkthroughExtensive edits to Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
551b8da to
e6a99a7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16175: Several auto-generated job names contain a typo: "invaid-fields"
should be "invalid-fields" (e.g.
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28
and the corresponding vsphere-ipi variants across 4.16–4.22); fix this by
updating the upstream job definitions used by openshift/ci-tools
sippy-config-generator to replace "invaid-fields" with "invalid-fields" for the
nutanix-ipi-zones and vsphere-ipi job name patterns (14 occurrences total), then
re-run the generator to regenerate config so the generated openshift.yaml no
longer contains the typo.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
config/openshift.yamlpkg/variantregistry/snapshot.yaml
🔇 Additional comments (9)
config/openshift.yaml (9)
1-1: LGTM!Auto-generated timestamp header is standard for machine-generated configuration files.
8850-8851: LGTM!New OADP QE automation jobs for AWS testing follow the established naming convention and are properly placed in alphabetical order within the 4.19 release configuration.
9051-9051: LGTM!CNF RAN ZTP test job addition is consistent with existing CNF job patterns.
10828-10828: LGTM!Baremetal OVE compact agent jobs added consistently for both 4.20 and 4.21 releases.
Also applies to: 12760-12760
11675-11676: LGTM!Multi-arch baremetal jobs added consistently across releases 4.20, 4.21, and 4.22 with proper f28 frequency designation.
Also applies to: 13636-13637, 15589-15590
12235-12236: LGTM!MicroShift OCP conformance jobs (including serial variant) added consistently across releases 4.20, 4.21, and 4.22.
Also applies to: 14290-14291, 16212-16213
12841-12844: LGTM!Four new Hive weekly e2e jobs added for release 4.21, covering Azure, GCP, pool, and general weekly test schedules. The jobs reference
masterbranch which is typical for Hive periodic jobs that track the latest code while being associated with a specific OCP release.
16074-16184: Comprehensive verification test coverage for 4.22.Large addition of ~110 verification tests covering multiple cloud providers (AWS, Azure, GCP, IBM Cloud, Nutanix, vSphere) with various configuration scenarios including:
- IPI/UPI installation methods
- IAM profiles and roles
- Network configurations (proxy, DNS, subnets)
- Disk types and boot diagnostics
- OIDC and identity management
- Multi-arch and ARM configurations
The YAML multi-line key syntax (using
?and:) for long job names is correctly applied.
16146-16146: No action needed. The job namenon-emtyp-rgis the correct name from the upstream CI system, not a typo. It appears consistently across multiple OpenShift versions (4.18–4.22) in both the configuration and the variant registry snapshot.Likely an incorrect or invalid review comment.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| : true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-ibmcloud-ipi-private-sshkey-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-ibmcloud-ipi-subnet-paging-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28: true |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, verify the file exists and check the specific lines
wc -l config/openshift.yaml
echo "=== Checking line 16175 ==="
sed -n '16175p' config/openshift.yaml
echo "=== Checking line 16181 ==="
sed -n '16181p' config/openshift.yamlRepository: openshift/sippy
Length of output: 388
🏁 Script executed:
# Search for all occurrences of invaid-fields and invalid-fields
echo "=== Searching for invaid-fields ==="
rg -n "invaid-fields" config/openshift.yaml
echo "=== Searching for invalid-fields ==="
rg -n "invalid-fields" config/openshift.yamlRepository: openshift/sippy
Length of output: 1931
🏁 Script executed:
# Check if there's any header/metadata indicating auto-generation
head -50 config/openshift.yamlRepository: openshift/sippy
Length of output: 3556
Fix typo in upstream job definitions: "invaid" should be "invalid".
The file contains 14 job names with invaid-fields across OpenShift versions 4.16–4.22. Both the nutanix-ipi-zones and vsphere-ipi variants are affected. Since this is auto-generated configuration from openshift/ci-tools sippy-config-generator, the fix should be applied to the upstream job definitions rather than in this generated file.
🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 16175, Several auto-generated job names
contain a typo: "invaid-fields" should be "invalid-fields" (e.g.
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28
and the corresponding vsphere-ipi variants across 4.16–4.22); fix this by
updating the upstream job definitions used by openshift/ci-tools
sippy-config-generator to replace "invaid-fields" with "invalid-fields" for the
nutanix-ipi-zones and vsphere-ipi job name patterns (14 occurrences total), then
re-run the generator to regenerate config so the generated openshift.yaml no
longer contains the typo.
e6a99a7 to
ddf5a33
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16147: The job name
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty"); fix the upstream job definition in the
source repository (where the job is defined for openshift/ci-tools
sippy-config-generator), rename the job to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28,
then re-run the sippy-config-generator to regenerate config/openshift.yaml so
the corrected job name is propagated.
♻️ Duplicate comments (1)
config/openshift.yaml (1)
16178-16184: Typo in upstream job definitions: "invaid" should be "invalid" (duplicate).Lines 16178 and 16184 contain job names with the typo
invaid-fieldsinstead ofinvalid-fields. This issue was already flagged in a previous review comment. Since this is auto-generated configuration, the fix should be applied upstream in the job definitions used byopenshift/ci-tools sippy-config-generator.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
config/openshift.yamlpkg/variantregistry/snapshot.yaml
🔇 Additional comments (2)
config/openshift.yaml (2)
12841-12844: New Hive periodic weekly jobs for release 4.21 look good.The addition of four Hive e2e weekly test jobs (azure-weekly, gcp-weekly, pool-weekly, e2e-weekly) extends the periodic testing coverage as expected. The jobs follow the established naming conventions.
16075-16187: Extensive 4.22 verification test coverage addition.This block adds comprehensive verification test jobs for release 4.22 covering AWS, Azure (including MAG and Stack variants), GCP, IBM Cloud, Nutanix, and vSphere platforms. The jobs follow established patterns from earlier releases. Apart from the typos noted separately, the configuration additions are consistent and correctly structured.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
ddf5a33 to
4062ff5
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
4062ff5 to
c897567
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
c897567 to
0e83203
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
0e83203 to
b14ad55
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
b14ad55 to
5a10210
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
5a10210 to
746cb33
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
746cb33 to
0f8674d
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
0f8674d to
50e9588
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
50e9588 to
9dd4acc
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16148: The job key
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty") and is coming from the auto-generated
config; locate the upstream OpenShift CI job definition in the variant registry
(source of config/openshift.yaml), correct the job name to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28
in the upstream definition, then regenerate config/openshift.yaml from the
variant registry so the corrected name replaces the invalid key rather than
hand-editing the generated file.
♻️ Duplicate comments (1)
config/openshift.yaml (1)
16180-16180: Typo "invaid-fields" in job names persists from upstream.These job names contain the typo "invaid-fields" instead of "invalid-fields":
- Line 16180:
...-nutanix-ipi-zones-invaid-fields-f28- Line 16186:
...-vsphere-ipi-invaid-fields-f28This was already flagged in a previous review. The fix needs to be applied to the upstream job definitions in
openshift/ci-tools sippy-config-generator.Also applies to: 16186-16186
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-duplicate-dns-arm-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-instance-type-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-mixed-publish-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28: true |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's confirm the typo exists at line 16148 in config/openshift.yaml
sed -n '16148p' config/openshift.yamlRepository: openshift/sippy
Length of output: 181
🏁 Script executed:
# Check if commit 0f8674d exists and what it changed
git log --oneline | grep 0f8674d || echo "Commit not found in log"Repository: openshift/sippy
Length of output: 82
🏁 Script executed:
# Search for references to this job name in the git history
git log -p --all -S "emtyp" --oneline -- config/openshift.yaml | head -100Repository: openshift/sippy
Length of output: 41
🏁 Script executed:
# Check git log for this specific file to understand its history
git log --oneline config/openshift.yaml | head -20Repository: openshift/sippy
Length of output: 117
🏁 Script executed:
# Look for any scripts or documentation that might generate this file
find . -type f \( -name "*.sh" -o -name "*.py" -o -name "README*" -o -name "*.md" \) | xargs grep -l "openshift.yaml" 2>/dev/null | head -10Repository: openshift/sippy
Length of output: 197
🏁 Script executed:
# Search for any comments or documentation about the job name or upstream fixes
grep -r "emtyp\|empty" config/openshift.yaml | head -5Repository: openshift/sippy
Length of output: 673
🏁 Script executed:
# Check DEVELOPMENT.md for details on how config is generated
cat -n DEVELOPMENT.md | grep -A 20 -B 5 "openshift.yaml\|generate\|update"Repository: openshift/sippy
Length of output: 5826
🏁 Script executed:
# Check the Claude command for more context
cat ./.claude/commands/sippy-update-job-variant.mdRepository: openshift/sippy
Length of output: 10016
Remove the invalid commit reference; the typo persists in auto-generated config from upstream source.
The job name contains the typo "emtyp" (should be "empty"). Since config/openshift.yaml is auto-generated from the variant registry system, verify the upstream OpenShift CI job definition and regenerate the config if the upstream issue has been resolved.
🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 16148, The job key
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty") and is coming from the auto-generated
config; locate the upstream OpenShift CI job definition in the variant registry
(source of config/openshift.yaml), correct the job name to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28
in the upstream definition, then regenerate config/openshift.yaml from the
variant registry so the corrected name replaces the invalid key rather than
hand-editing the generated file.
9dd4acc to
8921777
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 10812: Replace the typo "ove-compact" with "ovn-compact" in the job name
strings (e.g., change
periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60
and the analogous 4.21 entry) so they match the standard "ovn-compact" naming
used elsewhere; update any matching keys/occurrences in the job definition to
keep names consistent, then regenerate the upstream job definitions.
♻️ Duplicate comments (2)
config/openshift.yaml (2)
16141-16141: Typo "emtyp" → "empty" in upstream job definition.This typo was flagged in a previous review. Since
config/openshift.yamlis auto-generated, the fix must be applied to the upstream job definition in the verification-tests repository, then regenerated.
16173-16173: Typos "invaid" → "invalid" in upstream job definitions.These typos were flagged in a previous review. Both
nutanix-ipi-zones-invaid-fieldsandvsphere-ipi-invaid-fieldsshould be corrected toinvalid-fieldsin the upstream verification-tests job definitions, then the config should be regenerated.Also applies to: 16179-16179
| periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-ha-agent-ipv4-static-disc-fips-f7: true | ||
| periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-ha-agent-ipv6-dynamic-f7: true | ||
| periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-ha-agent-platform-none-ipv4-static-f7: true | ||
| periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60: true |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if "ove" appears elsewhere or if this is consistent
echo "=== Jobs containing 'ove-compact' ==="
rg -n "ove-compact" config/openshift.yaml | head -20
echo ""
echo "=== Jobs containing 'ovn-compact' for comparison ==="
rg -n "ovn-compact" config/openshift.yaml | head -20
echo ""
echo "=== Count occurrences ==="
echo "ove-compact occurrences: $(rg -c 'ove-compact' config/openshift.yaml || echo '0')"
echo "ovn-compact occurrences: $(rg -c 'ovn-compact' config/openshift.yaml || echo '0')"
echo ""
echo "=== Show context around line 10812 ==="
sed -n '10810,10815p' config/openshift.yamlRepository: openshift/sippy
Length of output: 2075
Job name contains likely typo: "ove-compact" should be "ovn-compact"
The job name baremetal-ove-compact-agent uses "ove" which is not a recognized OpenShift abbreviation. The standard networking abbreviation is "ovn" (Open Virtual Network). This pattern appears in only 2 jobs (4.20 and 4.21 releases), while "ovn-compact" is the standard naming convention elsewhere in the configuration. Correct this in the upstream job definition before regenerating.
🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 10812, Replace the typo "ove-compact" with
"ovn-compact" in the job name strings (e.g., change
periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60
and the analogous 4.21 entry) so they match the standard "ovn-compact" naming
used elsewhere; update any matching keys/occurrences in the job definition to
keep names consistent, then regenerate the upstream job definitions.
8921777 to
da3fa20
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
da3fa20 to
b6abc12
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
b6abc12 to
cae047f
Compare
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
cae047f to
b535d43
Compare
|
Scheduling required tests: |
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
b535d43 to
6509b43
Compare
|
Scheduling required tests: |
|
@openshift-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
/cc @