api: adapt hypershift verification test to be multi-module

[patrickdillon]

The hypershift verification test needs to be vendor both the root and api modules.

Trying this a second time because rehearsals seem broken on my earlier PR

Summary by CodeRabbit

The Hypershift verification test now supports multi-module repositories. It vendors both the API module and the root module before running make api test-envtest-api-all. This updates OpenShift CI validation for repositories that use separate root and API Go modules.

[coderabbitai]

Walkthrough

The verify-hypershift-integration test now vendors the Hypershift API submodule and repository root module before running API and envtest checks. It also configures local module replacements and updates Go module metadata.

Changes

Hypershift integration vendoring

Layer / File(s)	Summary
Vendor API and root modules ci-operator/config/openshift/api/openshift-api-master.yaml	The test vendors the API submodule first, then configures local replacements, runs go mod tidy, updates vendor/modules.txt, and vendors the repository root module.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#83089: Both PRs modify the verify-hypershift-integration test in the same configuration file.
• openshift/release#83260: This PR directly matches the related change for vendoring the API submodule and repository root module.

Suggested reviewers: joelspeed

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes adapting the Hypershift verification test for a multi-module setup.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only changed file is CI YAML; the diff adds vendoring commands and no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality	✅ Passed	The PR changes only CI YAML vendoring commands; it adds no Ginkgo It blocks or cluster-resource test code, so the listed Ginkgo quality checks are not applicable.
Microshift Test Compatibility	✅ Passed	The patch adds only CI vendoring commands in a YAML test job; it adds no Ginkgo tests or new OpenShift API references requiring MicroShift checks.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only a CI YAML command for Hypershift module vendoring; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The only change is CI shell commands in a YAML test definition to vendor Go modules; it adds no manifests, operator code, controllers, replicas, affinity, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a CI YAML shell script; it adds no Go OTE entry points or process-level stdout/logging code. The added echo commands are shell setup, not OTE binary output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests or network behavior; it only updates module vendoring commands in an existing CI YAML test.
No-Weak-Crypto	✅ Passed	The 12 added lines only modify Go module replacement, vendor metadata, tidy, and vendor commands; no weak-crypto algorithms, crypto APIs, custom crypto, or secret comparisons are introduced.
Container-Privileges	✅ Passed	The commit changes only a CI command block; it adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The 12 added lines only configure public GitHub module replacements and write public paths to vendor/modules.txt; no passwords, tokens, keys, PII, hostnames, or customer data are logged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/api/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[patrickdillon]

Retrying #83260 to see if I can get rehearsals to run on this one

[coderabbitai]

🧹 Nitpick comments (1)

ci-operator/config/openshift/api/openshift-api-master.yaml (1)

138-143: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Let go mod vendor generate vendor/modules.txt.

Remove the manual echo and sed commands from both vendoring steps. go mod vendor resets vendor and regenerates vendor/modules.txt, so these edits are discarded. The sed commands also depend on a v0.0.0 module version. Keep the replacements, then run go mod tidy and go mod vendor.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ci-operator/config/openshift/api/openshift-api-master.yaml` around lines 138
- 143, Remove the manual echo and sed edits targeting vendor/modules.txt from
both vendoring steps, leaving the existing replacements intact. Ensure each step
runs go mod tidy followed by go mod vendor so the vendor directory and
modules.txt are generated automatically.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@ci-operator/config/openshift/api/openshift-api-master.yaml`:
- Around line 138-143: Remove the manual echo and sed edits targeting
vendor/modules.txt from both vendoring steps, leaving the existing replacements
intact. Ensure each step runs go mod tidy followed by go mod vendor so the
vendor directory and modules.txt are generated automatically.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d16d125e-f723-4b8d-9107-08c4407b5d06

📥 Commits

Reviewing files that changed from the base of the PR and between 52a5dd4 and 7f044a0.

📒 Files selected for processing (1)

• ci-operator/config/openshift/api/openshift-api-master.yaml

[openshift-ci]

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/pj-rehearse

[openshift-merge-bot]

@patrickdillon: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.