Skip to content

Fix the day 2 worker CI job's ZTP git URLs - #82720

Open
rdiscala wants to merge 1 commit into
openshift:mainfrom
rdiscala:fix-ci-sno-day2-worker-ztp-git-urls
Open

Fix the day 2 worker CI job's ZTP git URLs#82720
rdiscala wants to merge 1 commit into
openshift:mainfrom
rdiscala:fix-ci-sno-day2-worker-ztp-git-urls

Conversation

@rdiscala

@rdiscala rdiscala commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updated the 4.14 and 4.16 SNO day 2 worker CI jobs to use the telcov10n ZTP Git repository instead of the rdiscala repository.

Signed-off-by: Rigel Di Scala <rdiscala@redhat.com>
@rdiscala
rdiscala marked this pull request as ready for review July 31, 2026 11:42
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The 4.14 and 4.16 CNF/RAN day-2 worker configurations now point ZTP_GIT_REPO to the telcov10n/ztp-site-configs-ci.git repository.

Changes

ZTP repository update

Layer / File(s) Summary
Update ZTP repository configuration
ci-operator/config/openshift-kni/eco-ci-cd/*cnf-ran-sno-day2-worker-4.14.yaml, ci-operator/config/openshift-kni/eco-ci-cd/*cnf-ran-sno-day2-worker-4.16.yaml
The ZTP_GIT_REPO value now uses the telcov10n repository namespace.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only ZTP_GIT_REPO URLs in two YAML files; it adds no Ginkgo test declarations or dynamic test titles.
Test Structure And Quality ✅ Passed The pull request changes only two YAML repository URLs and adds no Ginkgo tests or cluster operations to review.
Microshift Test Compatibility ✅ Passed The patch changes only two YAML ZTP_GIT_REPO URLs; it adds no Ginkgo tests or MicroShift-sensitive API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only two YAML ZTP repository URLs; it adds no Ginkgo tests or other test declarations requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The patch only changes ZTP_GIT_REPO URLs in two CI configuration files; it adds no deployment, affinity, topology spread, node targeting, replica, or disruption constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML ZTP_GIT_REPO values; no OTE binary, process-level code, or stdout/logging behavior changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only two YAML ZTP repository URLs; it adds no Ginkgo tests or test networking code covered by this check.
No-Weak-Crypto ✅ Passed The pull request changes only two ZTP repository URLs; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The patch changes only two ZTP_GIT_REPO URLs. The changed configs contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit only replaces two ZTP_GIT_REPO URLs. It adds no logging statements, credentials, tokens, or embedded authentication data.
Title check ✅ Passed The title clearly describes the change to the day 2 worker CI job's ZTP Git URLs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdiscala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rdiscala: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.16-cnf-ran-ztp-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.14-cnf-ran-ztp-tests N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@rdiscala: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant