NO-JIRA: Add optional TLS scanner CI job for secrets-store-csi-driver-operator

[arun717]

Summary

• Adds an optional, manually triggered tls-scanner presubmit for openshift/secrets-store-csi-driver-operator on main.
• The job provisions an Azure cluster using openshift-e2e-azure-csi-secrets-store, installs the operator via OLM into openshift-cluster-csi-drivers, enables TLS 1.3 strict adherence, and runs tls-scanner-run.
• Pattern follows STOR-3001: Add TLS scanner job to csi-operator for SMB #82657 and the cert-manager-operator TLS scanner job.

Test plan

• /pj-rehearse list confirms pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner is rehearsable
• /pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner succeeds
• On a secrets-store-csi-driver-operator PR against main, /test tls-scanner can trigger the job after this merges

Summary by CodeRabbit

Adds an optional, manually triggered tls-scanner presubmit job for openshift/secrets-store-csi-driver-operator on main.

The job provisions an Azure cluster, installs the operator through OLM, enables strict TLS 1.3 adherence, and runs tls-scanner-run with configured scanner resources.

[coderabbitai]

Walkthrough

The CI configuration adds a tls-scanner-tool base image and an optional Azure-based job. The job installs the operator bundle, waits for CSI driver readiness, applies strict TLS 1.3 settings, and runs scanner tests with dedicated resources.

Changes

TLS scanner CI integration

Layer / File(s)	Summary
Configure TLS scanner workflow ci-operator/config/openshift/secrets-store-csi-driver-operator/openshift-secrets-store-csi-driver-operator-main.yaml	The configuration adds the tls-scanner-tool base image and an optional Azure tls-scanner job. The job prepares the operator and CSI driver, enables strict TLS 1.3 adherence scanning, and runs tls-13 and tls-scanner-run with dedicated CPU and memory settings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant tlsScannerJob as tls-scanner job
  participant AzureWorkflow as Azure CSI workflow
  participant CSIDriver as CSI driver
  participant TLSScanner as TLS scanner tests
  tlsScannerJob->>AzureWorkflow: Install operator bundle
  AzureWorkflow->>CSIDriver: Configure readiness
  tlsScannerJob->>TLSScanner: Run tls-13 and tls-scanner-run

Loading

Possibly related PRs

• openshift/release#82133: Adds a similar TLS scanner job for a CSI operator.
• openshift/release#82657: Adds an optional TLS 1.3 scanner job for an Azure CSI workflow.
• openshift/release#82715: Adds a similar optional tls-scanner CI job with strict TLS 1.3 scanning.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Container-Privileges	❌ Error	The new tls-scanner job invokes tls-scanner-run, whose default branch generates a Pod with privileged: true, hostNetwork: true, hostPID: true, and runAsUser: 0.	Use a non-privileged scanner mode, or remove this scanner job. Do not generate privileged, host-networked, host-PID, root containers without an approved exception.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only static CI YAML and generated Prow YAML; no Ginkgo title constructs or dynamic test names were added.
Test Structure And Quality	✅ Passed	PASS: The PR changes only CI YAML files and adds no Ginkgo test code, so the listed Ginkgo test-quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The PR changes only CI YAML files and adds no Ginkgo test declarations or test source files, so MicroShift API compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only CI YAML configuration and generated presubmit job definitions; it adds no Ginkgo e2e test declarations or multi-node test assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only CI operator/job configuration and adds no affinity, topology spread, node selector, toleration, replica, or PDB scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two declarative YAML files; the patch adds no Go/source code, process-level logging, or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit adds only CI YAML and presubmit wiring; it adds no Ginkgo tests, IPv4 literals, or public-internet endpoints.
No-Weak-Crypto	✅ Passed	The patch adds CI configuration for a strict TLS 1.3 scanner and contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
No-Sensitive-Data-In-Logs	✅ Passed	The change adds only scanner configuration and standard CI secret mounts; it introduces no logging commands or secret, token, API-key, PII, or customer-data output.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the optional TLS scanner CI job added for the secrets-store-csi-driver-operator.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arun717
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/secrets-store-csi-driver-operator/OWNERS
• ci-operator/jobs/openshift/secrets-store-csi-driver-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@arun717: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Adds an optional, manually triggered tls-scanner presubmit for openshift/secrets-store-csi-driver-operator on main.
• The job provisions an Azure cluster using openshift-e2e-azure-csi-secrets-store, installs the operator via OLM into openshift-cluster-csi-drivers, enables TLS 1.3 strict adherence, and runs tls-scanner-run.
• Pattern follows STOR-3001: Add TLS scanner job to csi-operator for SMB #82657 and the cert-manager-operator TLS scanner job.

Test plan

• /pj-rehearse list confirms pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner is rehearsable
• /pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner succeeds
• On a secrets-store-csi-driver-operator PR against main, /test tls-scanner can trigger the job after this merges

Summary by CodeRabbit

Adds an optional, manually triggered tls-scanner presubmit job for openshift/secrets-store-csi-driver-operator on main.

The job provisions an Azure cluster, installs the operator through OLM, enables strict TLS 1.3 adherence, and runs tls-scanner-run with configured scanner resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@arun717: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner	openshift/secrets-store-csi-driver-operator	presubmit	Presubmit changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-ci-index-secrets-store-csi-driver-operator-bundle	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-fips-image-scan-mustgather	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-fips-image-scan-operator	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-images	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-aws	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-azure	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-azure-rhcos10	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-azure-rhcos10-fips	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-fips	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-gcp	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-vault-fips	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-security	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-unit	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-verify	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-verify-deps	openshift/secrets-store-csi-driver-operator	presubmit	Ci-operator config changed
periodic-ci-openshift-secrets-store-csi-driver-operator-main-operator-e2e-aws-weekly	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[arun717]

/pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner

[openshift-merge-bot]

@arun717: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@arun717: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/secrets-store-csi-driver-operator/main/tls-scanner	0765f4e	link	unknown	/pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.