fix(fleetshift): use repo root as build context for fleetshift-web - #82716
fix(fleetshift): use repo root as build context for fleetshift-web#82716Hyperkid123 wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughThe Fleetshift AIO and UI image build configurations now reference ChangesFleetshift image builds
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Hyperkid123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Dockerfile.web moved to repo root in fleetshift-poc. Remove context_dir: fleetshift-ui and update dockerfile_path to Dockerfile.web (now at repo root alongside Dockerfile, Dockerfile.local, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5dcaa75 to
6b95565
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Summary
context_dir: fleetshift-uifrom__ui.yamland__aio.yamlci-operator configsdockerfile_pathfromDockerfile.webtofleetshift-ui/Dockerfile.webThe
fleetshift-ui/Dockerfile.webwas updated in fleetshift-poc to use the monorepo root as build context — it now COPYspackage.json,package-lock.json, andtsconfig.jsonfrom the repo root, and references source paths asfleetshift-ui/common/,fleetshift-ui/gui/, etc.With
context_dir: fleetshift-ui, the Docker build context was restricted to thefleetshift-ui/subdirectory, so root-level files were unavailable — causingCOPY package.json package-lock.json ./to fail.Removing
context_dirdefaults to repo root, matching what the Dockerfile expects.🤖 Generated with Claude Code
Summary by CodeRabbit
Updates Fleetshift UI CI image builds to use the repository root as the Docker build context. The
__ui.yamland__aio.yamlconfigurations now referencefleetshift-ui/Dockerfile.webdirectly and no longer setcontext_dir: fleetshift-ui.