Skip to content

fix(fleetshift): use repo root as build context for fleetshift-web - #82716

Draft
Hyperkid123 wants to merge 1 commit into
openshift:mainfrom
Hyperkid123:fleetshift-web-build-context
Draft

fix(fleetshift): use repo root as build context for fleetshift-web#82716
Hyperkid123 wants to merge 1 commit into
openshift:mainfrom
Hyperkid123:fleetshift-web-build-context

Conversation

@Hyperkid123

@Hyperkid123 Hyperkid123 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove context_dir: fleetshift-ui from __ui.yaml and __aio.yaml ci-operator configs
  • Update dockerfile_path from Dockerfile.web to fleetshift-ui/Dockerfile.web

The fleetshift-ui/Dockerfile.web was updated in fleetshift-poc to use the monorepo root as build context — it now COPYs package.json, package-lock.json, and tsconfig.json from the repo root, and references source paths as fleetshift-ui/common/, fleetshift-ui/gui/, etc.

With context_dir: fleetshift-ui, the Docker build context was restricted to the fleetshift-ui/ subdirectory, so root-level files were unavailable — causing COPY package.json package-lock.json ./ to fail.

Removing context_dir defaults to repo root, matching what the Dockerfile expects.

🤖 Generated with Claude Code

Summary by CodeRabbit

Updates Fleetshift UI CI image builds to use the repository root as the Docker build context. The __ui.yaml and __aio.yaml configurations now reference fleetshift-ui/Dockerfile.web directly and no longer set context_dir: fleetshift-ui.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 45efb996-7ebf-4cb4-a87a-647cf614d74d

📥 Commits

Reviewing files that changed from the base of the PR and between 5dcaa75 and 6b95565.

📒 Files selected for processing (2)
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__aio.yaml
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__ui.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__ui.yaml
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__aio.yaml

Walkthrough

The Fleetshift AIO and UI image build configurations now reference fleetshift-ui/Dockerfile.web directly. Separate context_dir settings were removed.

Changes

Fleetshift image builds

Layer / File(s) Summary
Use direct web Dockerfile paths
ci-operator/config/fleetshift/fleetshift-poc/*
Both image build configurations remove separate context directory settings and use the repository-relative fleetshift-ui/Dockerfile.web path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: using the repository root as the Fleetshift web build context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only two ci-operator YAML files and removes build-context settings; it adds or modifies no Ginkgo test declarations or test titles.
Test Structure And Quality ✅ Passed The commit changes only two ci-operator YAML files by removing context_dir; it adds no Ginkgo tests or cluster operations, so these requirements are not applicable.
Microshift Test Compatibility ✅ Passed The commit changes only two ci-operator YAML files and adds no Ginkgo e2e tests or unsupported API references; the MicroShift test check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request adds no Ginkgo e2e tests. It only removes context_dir from two YAML build configurations, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only removes ci-operator Docker build context_dir entries; it adds or modifies no deployment manifests, operators, controllers, replicas, affinities, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract ✅ Passed The pull request changes only two ci-operator YAML files; it adds no Go or OTE process-level code and therefore introduces no stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only two ci-operator YAML files and adds no Ginkgo e2e tests or new network operations, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The PR only deletes context_dir: fleetshift-ui from two YAML files; no weak-crypto primitive, custom crypto, or secret comparison is added.
Container-Privileges ✅ Passed The PR only removes context_dir: fleetshift-ui from two CI image configs; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The pull request only deletes two context_dir YAML lines. It adds no logging code and no sensitive-data fields or values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hyperkid123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
Dockerfile.web moved to repo root in fleetshift-poc. Remove
context_dir: fleetshift-ui and update dockerfile_path to Dockerfile.web
(now at repo root alongside Dockerfile, Dockerfile.local, etc.).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Hyperkid123
Hyperkid123 force-pushed the fleetshift-web-build-context branch from 5dcaa75 to 6b95565 Compare July 31, 2026 11:11
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Hyperkid123: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-fleetshift-fleetshift-poc-main-aio-images fleetshift/fleetshift-poc presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-poc-main-aio-pr-image-mirror fleetshift/fleetshift-poc presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-poc-main-ui-images fleetshift/fleetshift-poc presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-poc-main-ui-pr-image-mirror fleetshift/fleetshift-poc presubmit Ci-operator config changed
periodic-ci-fleetshift-fleetshift-poc-main-aio-republish-latest N/A periodic Ci-operator config changed
periodic-ci-fleetshift-fleetshift-poc-main-ui-republish-latest N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant