[faas-console-plugin] Fix misconfigured promotion to payload

[dsimansk]

Changes

• Remove promotion block entirely
• Remove version variants added by config-brancher
  • I'll create an issue to remove the unused versioned branches to prevent further configs to be generated

/cc @twoGiants @pmeida @matejvasek

Summary by CodeRabbit

• Removed the faas-console-plugin promotion configuration that published images to the 5.0 release in the ocp namespace.
• Deleted generated release configurations for releases 4.23, 5.0, and 5.1.
• Prevents config-brancher from maintaining unused version variants.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6e804898-db04-482a-9adc-3a541ed7e873

📥 Commits

Reviewing files that changed from the base of the PR and between 33a9bd9 and 260f827.

⛔ Files ignored due to path filters (8)

• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-master-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-release-4.23-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.0-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.1-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (4)

• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml
• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-4.23.yaml
• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.0.yaml
• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.1.yaml

💤 Files with no reviewable changes (4)

• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-4.23.yaml
• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.0.yaml
• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml
• ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.1.yaml

---

Walkthrough

The change removes the faas-console-plugin image promotion target for release 5.0 and deletes the release-specific CI configurations for releases 4.23, 5.0, and 5.1.

Changes

faas-console-plugin CI configuration

Layer / File(s)

Summary

Remove release promotion and configurations ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml, ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-4.23.yaml, ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.0.yaml, ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-release-5.1.yaml

The master configuration no longer promotes the image to the 5.0 release in the ocp namespace. The release-specific CI configuration files are deleted.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the faas-console-plugin promotion fix, which matches the main changes in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only CI YAML and generated job files; the complete patch contains no Ginkgo test-title declarations or dynamic test names.
Test Structure And Quality	✅ Passed	The patch changes only YAML CI configuration and generated job files; it adds or modifies no Ginkgo test code, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	The pull request only removes CI YAML configuration and job files; it adds no Ginkgo e2e tests or test code that could use MicroShift-incompatible APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The patch contains only deletions in 12 YAML configuration and job files; it adds no Ginkgo tests or topology-sensitive test code.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only CI YAML: it removes promotion entries and three generated config files; it adds or modifies no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	HEAD changes only ci-operator YAML files; no OTE binary, Ginkgo suite setup, klog use, or process-level stdout code is introduced or modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds no lines and introduces no Ginkgo e2e tests; it only removes CI configuration and job files.
No-Weak-Crypto	✅ Passed	The parent-to-HEAD patch adds 0 lines and contains no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto API, or secret-comparison usage.
Container-Privileges	✅ Passed	The changed CI YAML adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution setting.
No-Sensitive-Data-In-Logs	✅ Passed	The commit adds no lines. It only removes promotion, release configurations, and a CI target; no logging or sensitive-data output is introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@dsimansk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-faas-console-plugin-master-images	openshift/faas-console-plugin	presubmit	Presubmit changed
pull-ci-openshift-faas-console-plugin-master-lint	openshift/faas-console-plugin	presubmit	Ci-operator config changed
pull-ci-openshift-faas-console-plugin-master-unit	openshift/faas-console-plugin	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@dsimansk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pmeida]

/lgtm
/approve

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pmeida

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/faas-console-plugin/OWNERS [dsimansk]
• ci-operator/jobs/openshift/faas-console-plugin/OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

Moving on to prevent further updates on release branches.
/unhold