Skip to content

INTEROP-9257: Add daily trigger and watcher-bot for ACM+Virt jobs - #82702

Draft
sg-rh wants to merge 1 commit into
openshift:mainfrom
sg-rh:interop-9257-acm-virt-triggering
Draft

INTEROP-9257: Add daily trigger and watcher-bot for ACM+Virt jobs#82702
sg-rh wants to merge 1 commit into
openshift:mainfrom
sg-rh:interop-9257-acm-virt-triggering

Conversation

@sg-rh

@sg-rh sg-rh commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Add daily triggering for the ACM+Virt interop jobs (P2P upgrade + live migration) via the existing trigger-jobs orchestrator mechanism.

New entries in weekly_trigger.yaml:

  • acm-virt-interop-trigger — cron 0 6 * * * (daily 6 AM UTC): triggers both ACM+Virt periodic jobs via the Gangway API using Vault key acm-virt-interop
  • acm-virt-interop-watcher-bot-message — cron 0 20 * * * (daily 8 PM UTC): sends Slack summary of triggered jobs' results

Background

This is part of the Component Readiness (CR) integration for ACM+Virt testing (Epic INTEROP-9203). CR requires a minimum of 7 job runs per week, so daily triggering satisfies that requirement.

The ACM+Virt jobs have disabled crons (0 23 31 2 *) and rely on the trigger-jobs orchestrator to fire them. This PR adds the orchestrator entries following the same pattern as OPP (opp-interop-jobs-trigger).

Vault key: already created

Related PRs

Test plan

  • Verify Vault key acm-virt-interop contains correct job names
  • Prow rehearsal validates generated config
  • After merge: confirm trigger fires at 6 AM UTC and watcher-bot reports at 8 PM UTC

@coderabbitai ignore

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 31, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

@sg-rh: This pull request references INTEROP-9257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add daily triggering for the ACM+Virt interop jobs (P2P upgrade + live migration) via the existing trigger-jobs orchestrator mechanism.

New entries in weekly_trigger.yaml:

  • acm-virt-interop-trigger — cron 0 6 * * * (daily 6 AM UTC): triggers both ACM+Virt periodic jobs via the Gangway API using Vault key acm-virt-interop
  • acm-virt-interop-watcher-bot-message — cron 0 20 * * * (daily 8 PM UTC): sends Slack summary of triggered jobs' results

Background

This is part of the Component Readiness (CR) integration for ACM+Virt testing (Epic INTEROP-9203). CR requires a minimum of 7 job runs per week, so daily triggering satisfies that requirement.

The ACM+Virt jobs have disabled crons (0 23 31 2 *) and rely on the trigger-jobs orchestrator to fire them. This PR adds the orchestrator entries following the same pattern as OPP (opp-interop-jobs-trigger).

Vault key: acm-virt-interop (already created in selfservice/cspi-qe/cluster-secrets)

Slack channel: Currently set to #forum-p2p-cspi — confirming with team whether to use #team-qe-lp-triage instead (matching OPP pattern).

Related PRs

Test plan

  • Confirm Slack channel with team (#forum-p2p-cspi vs #team-qe-lp-triage)
  • Verify Vault key acm-virt-interop contains correct job names
  • Prow rehearsal validates generated config
  • After merge: confirm trigger fires at 6 AM UTC and watcher-bot reports at 8 PM UTC

@coderabbitai ignore

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@openshift-ci-robot Acknowledged. INTEROP-9257 needs its Jira Target Version set to 5.0.0 to satisfy the target-branch requirement. This is Jira metadata only; it does not require a change to this PR’s repository configuration.

You are interacting with an AI system.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@sg-rh
INTEROP-9257: Add daily trigger and watcher-bot for ACM+Virt jobs
eb69b50 
Add acm-virt-interop-trigger (cron 0 6 * * *) and
acm-virt-interop-watcher-bot-message (cron 0 20 * * *) entries
to the weekly_trigger config. The trigger reads the Vault key
acm-virt-interop to fire the ACM+Virt P2P and live migration
periodic jobs daily.
@sg-rh
sg-rh force-pushed the interop-9257-acm-virt-triggering branch from aa19bac to eb69b50 Compare July 31, 2026 00:14
@openshift-merge-bot

openshift-merge-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sg-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-rhpit-interop-tests-main-weekly_trigger-acm-virt-interop-watcher-bot-message N/A periodic Periodic changed
periodic-ci-rhpit-interop-tests-main-weekly_trigger-acm-virt-interop-trigger N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

amp-rh
amp-rh reviewed Jul 31, 2026
View reviewed changes

@amp-rh amp-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: INTEROP-9257 ACM+Virt Daily Trigger

Overall: Clean, pattern-following addition. No blocking issues.

Suggestions (non-blocking)

  1. Monday timing overlap (Low): Trigger fires at 0 6 * * * which overlaps with ocp-self-managed-lp-interop--fips--422 at 0 6 * * 1. Both use aws-cspi-qe cluster profile. Since trigger-jobs just calls Gangway (no cluster provisioning), this likely won't cause contention, but staggering by 30 min (e.g., 30 5 * * *) would eliminate any chance of lease conflicts.

  2. Release version confirmation (Low): The variant-level releases.latest.candidate.version: "4.22" applies to these entries. Confirm the downstream ACM+Virt periodic jobs actually target 4.22.

  3. Naming pattern (Info): Test name uses acm-virt-interop-trigger while OPP uses opp-interop-jobs-trigger (with "jobs" suffix). Minor inconsistency but the Vault key acm-virt-interop matches JT__TRIG_JOB_LIST correctly.

Verified

  • Firewatch classification and labels correctly differentiated
  • Watcher-bot uses daily-trigger-lp label (matches actual cadence)
  • 14-hour gap between trigger (6 AM) and watcher-bot (8 PM) is reasonable
  • Reporter config propagated to both entries
  • Auto-generated periodics.yaml matches prowgen conventions

@amp-rh

amp-rh commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amp-rh, sg-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@amp-rh amp-rh amp-rh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@amp-rh amp-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sg-rh @openshift-ci-robot @amp-rh