AGENT-1572: Run ISO-no-registry presubmit job for assisted-installer

[pawanpinjarkar]

Run ISO-no-registry presubmit job for assisted-installer

Summary by CodeRabbit

Adds an optional ISO-without-registry end-to-end presubmit job for assisted-installer across the master and release 4.22–5.1 CI configurations. The job uses the compact IPv4 workflow on Equinix metal, requires intranet access, and skips documentation- and metadata-only changes.

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1572 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Run ISO-no-registry presubmit job for assisted-installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/pj-rehearse

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b1d09bd6-a07d-41a0-be6a-9e74ba8f7e12

📥 Commits

Reviewing files that changed from the base of the PR and between b9df980 and daebbf8.

⛔ Files ignored due to path filters (5)

• ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-master-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (5)

• ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-master.yaml
• ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-4.22.yaml
• ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-4.23.yaml
• ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-5.0.yaml
• ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-5.1.yaml

---

Walkthrough

Adds the optional e2e-agent-compact-ipv4-iso-no-registry test to assisted-installer CI configurations for master and releases 4.22, 4.23, 5.0, and 5.1.

Changes

Assisted installer CI configuration

Layer / File(s)	Summary
Register compact IPv4 ISO test ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-*.yaml	Adds the optional test with the agent-e2e-compact-ipv4-iso-no-registry workflow, equinix-ocp-metal cluster profile, intranet capability, non-default execution where specified, and file-based skip rules.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• openshift/release#82686: Adds a related serial conformance variant for the same compact IPv4 ISO without registry scenario.

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	⚠️ Warning	The added iso-no-registry workflow validates with oc get clusterversion and oc get csv -A, both unavailable on MicroShift, with no MicroShift skip/guard.	Add a MicroShift guard/skip for this workflow or tag the test so MicroShift CI excludes it; otherwise it will fail on MicroShift clusters.
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	The added job uses agent-e2e-compact-ipv4-iso-no-registry, and its workflow docs say it adds a couple of nodes after deployment; no SNO guard was found.	Add a [Skipped:SingleReplicaTopology] label or runtime SNO skip, or keep this presubmit off SNO-sensitive jobs.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding the ISO-no-registry presubmit job for assisted-installer.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only static CI job names were added in YAML; no Ginkgo test titles or dynamic identifiers were introduced.
Test Structure And Quality	✅ Passed	PASS: The PR only adds ci-operator YAML presubmit entries; no Ginkgo test code changed, so this code-quality check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only ci-operator test configs were added; no manifests/controllers with scheduling constraints were changed.
Ote Binary Stdout Contract	✅ Passed	Only CI YAML job definitions were added; no binary/runtime code or stdout-writing process setup changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only adds presubmit/config YAML for an existing workflow; no Ginkgo test code or network logic changed, so this check is not applicable.
No-Weak-Crypto	✅ Passed	The PR only adds CI job YAML entries; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the changed configs.
Container-Privileges	✅ Passed	Touched CI config only adds a job stanza; scans found no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields.
No-Sensitive-Data-In-Logs	✅ Passed	The change only adds CI test metadata; the new stanzas contain no log statements, secrets, tokens, or PII.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign omer-vishlitzky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/assisted-installer/OWNERS
• ci-operator/jobs/openshift/assisted-installer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-assisted-installer-master-e2e-agent-compact-ipv4-iso-no-registry	openshift/assisted-installer	presubmit	Presubmit changed
pull-ci-openshift-assisted-installer-release-4.22-e2e-agent-compact-ipv4-iso-no-registry	openshift/assisted-installer	presubmit	Presubmit changed
pull-ci-openshift-assisted-installer-release-4.23-e2e-agent-compact-ipv4-iso-no-registry	openshift/assisted-installer	presubmit	Presubmit changed
pull-ci-openshift-assisted-installer-release-5.0-e2e-agent-compact-ipv4-iso-no-registry	openshift/assisted-installer	presubmit	Presubmit changed
pull-ci-openshift-assisted-installer-release-5.1-e2e-agent-compact-ipv4-iso-no-registry	openshift/assisted-installer	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@pawanpinjarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/assisted-installer/release-5.1/e2e-agent-compact-ipv4-iso-no-registry	daebbf8	link	unknown	/pj-rehearse pull-ci-openshift-assisted-installer-release-5.1-e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pawanpinjarkar]

/pj-rehearse ack

[openshift-merge-bot]

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.