Skip to content

Add integration test presubmit for openshift/sippy - #82684

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:sippy-integration-presubmit
Open

Add integration test presubmit for openshift/sippy#82684
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:sippy-integration-presubmit

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Adds a new integration presubmit job for openshift/sippy that runs make integration against PRs.\n\nThis runs the Go integration tests in test/integration/... via gotestsum. The job mirrors the existing unit presubmit configuration (container-based, skip_if_only_changed for doc-only PRs).\n\nThe generated presubmit is pull-ci-openshift-sippy-main-integration, triggered by /test integration.\n\nRef: https://redhat.atlassian.net/browse/TRT-2865


@mstaeble requested in Slack thread

Summary by CodeRabbit

Adds an integration presubmit job for openshift/sippy. The job runs HOME=/tmp make integration in the source container, triggering Go integration tests via gotestsum for pull requests. It is available through /test integration and skips documentation-only or metadata-only changes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 1dabef33-c916-4ff1-9d89-d343dd575778

📥 Commits

Reviewing files that changed from the base of the PR and between cc5e91b and e8db9ec.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

Walkthrough

Adds an integration test entry to the Sippy CI configuration, running HOME=/tmp make integration in the src container with the existing documentation-only skip pattern.

Changes

Sippy integration test

Layer / File(s) Summary
Add integration test entry
ci-operator/config/openshift/sippy/openshift-sippy-main.yaml
Adds an integration test step using the src container and the existing skip_if_only_changed pattern.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: smg247

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding an integration presubmit for openshift/sippy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds CI job config; no Ginkgo test titles or test code were changed, so there are no unstable names to flag.
Test Structure And Quality ✅ Passed PR only adds a CI presubmit YAML entry; no Ginkgo test code was changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only a CI presubmit YAML entry was added; no new Ginkgo/test code was introduced, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds CI job YAML for make integration; no new Ginkgo/e2e test code was added, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI presubmit/config files changed; no deployment manifests, controllers, or scheduling logic were added or modified.
Ote Binary Stdout Contract ✅ Passed Only CI YAML changed; no main/init/suite code or stdout writes were added, so the OTE stdout contract isn’t affected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator config changed; no new Ginkgo/e2e test code was added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed PR only adds a CI integration presubmit in YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the changed files.
Container-Privileges ✅ Passed Only a new src-based integration test step was added; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation flags appear.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only a standard CI presubmit command; no new logging, debug output, or sensitive data exposure is introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deads2k and sosiouxme July 30, 2026 17:57
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-sippy-main-integration openshift/sippy presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/sippy/main/integration e8db9ec link unknown /pj-rehearse pull-ci-openshift-sippy-main-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant