Skip to content

OSASINFRA-4375: Drop build of legacy binary for openstack-test - #82674

Open
danchild wants to merge 1 commit into
openshift:mainfrom
shiftstack:remove-legacy-osp-test-ci-conf
Open

OSASINFRA-4375: Drop build of legacy binary for openstack-test#82674
danchild wants to merge 1 commit into
openshift:mainfrom
shiftstack:remove-legacy-osp-test-ci-conf

Conversation

@danchild

@danchild danchild commented Jul 30, 2026

Copy link
Copy Markdown
Member

Following the migration of OTE (OpenShift Test Extension for ShiftStack CI configs
(releases 4.20+), the legacy openstack-test binary
is no longer needed. Similarly, the build step fails in CI
when attempting to drop all legacy openstack-test related
code and artifacts for these releases.

Dependencies:
#81168
#82506

Summary by CodeRabbit

  • Removes the legacy openstack-tests binary build from OpenStack CI configurations for releases 4.20–5.1 and main.
  • Retains the tests-ext build and compressed artifact used by current OTE-based ShiftStack CI.
  • Prevents failures caused by building obsolete legacy code and artifacts.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@danchild danchild changed the title Drop build of legacy binary for openstack-test OSASINFRA-4375: Drop build of legacy binary for openstack-test Jul 30, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@danchild: This pull request references OSASINFRA-4375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Following the migration of OTE for ShiftStack CI configs
(releases 4.20+), the legacuy openstack-test binary
is no longer needed. Also, the build step will fail in CI
when attempting to drop all legacy openstack-test related
code and artifacts for these releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The OpenStack test CI configurations remove the go build step that produced /bin/openstack-tests. Each configuration retains the tests-ext build and gzip packaging commands.

Changes

OpenStack test build configuration

Layer / File(s) Summary
Remove openstack-tests compilation
ci-operator/config/openshift/openstack-test/*
All listed configurations remove the go build -o /bin/openstack-tests ./cmd/openshift-tests command while retaining the tests-ext build and gzip packaging commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only removes build commands in ci-operator YAML; no Ginkgo test titles or test code changed.
Test Structure And Quality ✅ Passed Only ci-operator YAML changed; no Ginkgo test code was modified, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only removes a build step in 7 ci-operator YAMLs; no Ginkgo tests or MicroShift-unsafe APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only removes a build step from 7 CI YAML configs; no Ginkgo tests or SNO-sensitive test code were added or changed.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator build-command YAML changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only edits ci-operator YAML build commands; no process-level code or stdout writes were added, and the legacy openstack-tests build step was removed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; PR only removes a legacy build step in ci-operator YAML, so IPv4/external-connectivity compatibility is not applicable.
No-Weak-Crypto ✅ Passed Only CI YAML build commands were removed; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the touched files.
Container-Privileges ✅ Passed Only build-command lines were removed; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear in the changed CI configs.
No-Sensitive-Data-In-Logs ✅ Passed The diff only removes a go build line from CI YAML; no new logging, secrets, hostnames, or PII are introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the legacy openstack-test binary build.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Following the migration of OTE for ShiftStack CI configs
(releases 4.20+), the legacy openstack-test binary
is no longer needed. Also, the build step will fail in CI
when attempting to drop all legacy openstack-test related
code and artifacts for these releases.

Signed-off-by: Dan Childers <dchilder@redhat.com>
@danchild
danchild force-pushed the remove-legacy-osp-test-ci-conf branch from 16e066f to 0131910 Compare July 30, 2026 15:06
@danchild
danchild marked this pull request as ready for review July 30, 2026 15:08
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2026
@openshift-ci
openshift-ci Bot requested review from eurijon and mandre July 30, 2026 15:08
@danchild

Copy link
Copy Markdown
Member Author

/assign @gryf

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danchild: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-openstack-test-release-4.23-build openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.23-e2e-openstack-ccpmso openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.23-e2e-openstack-dualstack openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.23-e2e-openstack-dualstack-v6primary openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.23-images openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.23-test openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.23-verify openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-build openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-e2e-openstack-ccpmso openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-e2e-openstack-dualstack openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-e2e-openstack-dualstack-v6primary openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-images openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-test openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-main-verify openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-build openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-e2e-openstack-ccpmso openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-e2e-openstack-dualstack openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-e2e-openstack-dualstack-v6primary openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-images openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-test openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.22-verify openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.20-build openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.20-e2e-openstack-ccpmso openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.20-e2e-openstack-dualstack openshift/openstack-test presubmit Ci-operator config changed
pull-ci-openshift-openstack-test-release-4.20-e2e-openstack-dualstack-v6primary openshift/openstack-test presubmit Ci-operator config changed

A total of 49 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@danchild: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ekuris-redhat ekuris-redhat left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danchild, ekuris-redhat
Once this PR has been reviewed and has the lgtm label, please ask for approval from gryf. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danchild

Copy link
Copy Markdown
Member Author

/verified by @danchild

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 31, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@danchild: This PR has been marked as verified by @danchild.

Details

In response to this:

/verified by @danchild

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants