Add disconnected AWS e2e tests to LVMS z-stream presubmits - #82670
Conversation
Add SNO and MNO disconnected test profiles to z-stream presubmit configs for versions 4.14, 4.16, 4.18, 4.19, 4.20, and 4.21. For 4.16+, tests use the openshift-e2e-aws-disconnected-lvms-sno/mno workflows. For 4.14, tests inline cucushift chains since the ipi-aws-pre-disconnected chain uses the CAPI installer which is incompatible with 4.14's Terraform-based installer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughRelease-management configurations for ZStreams 4.14, 4.16, 4.18, 4.19, 4.20, and 4.21 add UPI installer images and disconnected AWS SNO and MNO LVM operator integration jobs. ChangesZStream integration configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (6)
ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.21.yaml (1)
219-230: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winSame missing
set -euo pipefailas the other zstream files.See the consolidated comment at the end of this review for the shared fix across all 6 files.
Also applies to: 249-260
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.21.yaml` around lines 219 - 230, Update the shell command block in the zstream release-management configuration to enable strict failure handling with set -euo pipefail before executing the existing commands, including the similarly structured block referenced later. Keep the current command sequence unchanged.ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.19.yaml (1)
219-230: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winSame missing
set -euo pipefailas the other zstream files.See the consolidated comment at the end of this review for the shared fix across all 6 files.
Also applies to: 249-260
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.19.yaml` around lines 219 - 230, Add set -euo pipefail at the beginning of the commands script before sourcing proxy-conf.sh and running the git, Go, and integration-test commands. Apply the same change to the additional commands block referenced by the comment, preserving the existing command sequence.ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.18.yaml (1)
219-230: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winSame missing
set -euo pipefailas the other zstream files.See the consolidated comment at the end of this review for the shared fix across all 6 files.
Also applies to: 249-260
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.18.yaml` around lines 219 - 230, Add `set -euo pipefail` at the start of the shell script in the commands block before sourcing proxy-conf.sh and running the git/build/test steps. Apply the same change to the corresponding commands block referenced around the second range, preserving the existing command order.ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.20.yaml (1)
219-230: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winSame missing
set -euo pipefailas the other zstream files.See the consolidated comment at the end of this review for the shared fix across all 6 files.
Also applies to: 249-260
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.20.yaml` around lines 219 - 230, Update the shell script in the commands block to enable strict error handling with set -euo pipefail before executing the existing proxy setup, repository checkout, build, and test commands; apply the same change to the additional commands block around the referenced later section.ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.16.yaml (1)
219-230: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winSame missing
set -euo pipefailas the other zstream files.See the consolidated comment at the end of this review for the shared fix across all 6 files.
Also applies to: 249-260
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.16.yaml` around lines 219 - 230, Add set -euo pipefail at the beginning of the commands script before sourcing proxy-conf.sh or running any git, Go, or test commands. Apply the same change to both command blocks identified by the existing integration-test flow, preserving the remaining commands unchanged.ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.14.yaml (1)
234-245: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winHarden the integration-test command scripts against silent partial failures.
Neither script sets
set -euo pipefail. Ifgit fetch/go mod downloadfails, execution continues into subsequent steps (cd test/integration,go build, etc.) instead of failing fast, which can produce confusing downstream errors instead of a clear root cause.🛠️ Proposed fix
commands: | + set -euo pipefail if [ -f "${SHARED_DIR}/proxy-conf.sh" ]; then source "${SHARED_DIR}/proxy-conf.sh" fiThis same pattern repeats identically across all 6 zstream files reviewed in this PR; see the consolidated comment at the end of this review.
Also applies to: 276-287
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.14.yaml` around lines 234 - 245, Add strict shell error handling at the start of each affected commands script by enabling set -euo pipefail before sourcing proxy-conf.sh and running git/go commands. Apply this consistently to both script blocks in the zstream configuration and all six matching zstream files, preserving the existing command order.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.14.yaml`:
- Around line 234-245: Add strict shell error handling at the start of each
affected commands script by enabling set -euo pipefail before sourcing
proxy-conf.sh and running git/go commands. Apply this consistently to both
script blocks in the zstream configuration and all six matching zstream files,
preserving the existing command order.
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.16.yaml`:
- Around line 219-230: Add set -euo pipefail at the beginning of the commands
script before sourcing proxy-conf.sh or running any git, Go, or test commands.
Apply the same change to both command blocks identified by the existing
integration-test flow, preserving the remaining commands unchanged.
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.18.yaml`:
- Around line 219-230: Add `set -euo pipefail` at the start of the shell script
in the commands block before sourcing proxy-conf.sh and running the
git/build/test steps. Apply the same change to the corresponding commands block
referenced around the second range, preserving the existing command order.
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.19.yaml`:
- Around line 219-230: Add set -euo pipefail at the beginning of the commands
script before sourcing proxy-conf.sh and running the git, Go, and
integration-test commands. Apply the same change to the additional commands
block referenced by the comment, preserving the existing command sequence.
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.20.yaml`:
- Around line 219-230: Update the shell script in the commands block to enable
strict error handling with set -euo pipefail before executing the existing proxy
setup, repository checkout, build, and test commands; apply the same change to
the additional commands block around the referenced later section.
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.21.yaml`:
- Around line 219-230: Update the shell command block in the zstream
release-management configuration to enable strict failure handling with set -euo
pipefail before executing the existing commands, including the similarly
structured block referenced later. Keep the current command sequence unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3cc03eeb-6dae-4df0-9075-9cce44e6b54a
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/lvm-operator/openshift-lvm-operator-release-management-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (6)
ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.14.yamlci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.16.yamlci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.18.yamlci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.19.yamlci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.20.yamlci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-management__zstream-4.21.yaml
|
/pj-rehearse pull-ci-openshift-lvm-operator-release-management-zstream-4.14-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.16-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.18-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.19-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.20-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.21-e2e-aws-disc-sno-qe-integration-tests |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-lvm-operator-release-management-zstream-4.14-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.16-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.18-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.19-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.20-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.21-e2e-aws-disc-sno-qe-integration-tests |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-lvm-operator-release-management-zstream-4.14-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.16-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.18-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.19-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.20-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.21-e2e-aws-disc-sno-qe-integration-tests |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The ipi-aws-pre-disconnected chain's mirror-images-by-oc-adm step requires the upi-installer image. Add it as a base_images entry in z-stream configs for 4.16-4.21 to match the nightly configs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cd05be3 to
2b70d58
Compare
|
[REHEARSALNOTIFIER]
A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-lvm-operator-release-management-zstream-4.14-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.16-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.18-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.19-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.20-e2e-aws-disc-mno-qe-integration-tests pull-ci-openshift-lvm-operator-release-management-zstream-4.21-e2e-aws-disc-sno-qe-integration-tests |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kasturinarra, qJkee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest |
|
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
bbebeaf
into
openshift:main
2 participants
Summary
openshift-e2e-aws-disconnected-lvms-sno/mnoworkflowsipi-aws-pre-disconnecteduses the CAPI installer which is incompatible with 4.14's Terraform-based installerTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Adds disconnected AWS end-to-end SNO and MNO presubmit profiles for the LVM operator across z-stream releases 4.14, 4.16, 4.18, 4.19, 4.20, and 4.21.
The profiles:
upi-installerbase image required by disconnected image mirroring.proxy-conf.shwhen available.