Skip to content

[cluster-capi-operator] verify-deps: run go mod list - #82669

Open
simkam wants to merge 1 commit into
openshift:mainfrom
simkam:capi-operator-mod-list-check-on
Open

[cluster-capi-operator] verify-deps: run go mod list#82669
simkam wants to merge 1 commit into
openshift:mainfrom
simkam:capi-operator-mod-list-check-on

Conversation

@simkam

@simkam simkam commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

use default => true

- name: CHECK_MOD_LIST
default: "true"
documentation: |-
Whether go mod list check should be run.

it would find issues like openshift/cluster-capi-operator#639

Summary by CodeRabbit

  • Enables default dependency verification behavior for cluster-capi-operator, allowing the verify-deps CI job to run go mod list and detect dependency issues.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6754dfb8-2271-4c4a-a7fe-0e7e2458d50f

📥 Commits

Reviewing files that changed from the base of the PR and between 9146ed7 and e8897c2.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml

Walkthrough

The verify-deps CI job no longer sets CHECK_MOD_LIST: "false" while retaining its existing test reference configuration.

Changes

Verify dependencies configuration

Layer / File(s) Summary
Remove verify-deps environment override
ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml
Removes CHECK_MOD_LIST: "false" from the verify-deps job environment.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: enabling verify-deps to run go mod list for cluster-capi-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only removes CHECK_MOD_LIST from a CI config; no Ginkgo tests or test titles were added or changed.
Test Structure And Quality ✅ Passed The PR only changes a ci-operator YAML config; no Ginkgo test code or test behavior is modified, so the test-structure review is not applicable.
Microshift Test Compatibility ✅ Passed Only a ci-operator YAML changed; no new Ginkgo e2e tests were added, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a CI config YAML changed; no Ginkgo e2e tests were added or modified, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI verify-deps config changed; no deployment manifests, operator code, or scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed PR only changes a CI YAML job to use the default verify-deps setting; no process-level stdout code was added or modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo/e2e tests were added; the PR only removes a CI env var from a verify-deps config file.
No-Weak-Crypto ✅ Passed Only a CI config line was removed; the diff and changed file contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto patterns.
Container-Privileges ✅ Passed PASS: The only changed file removes CHECK_MOD_LIST from a CI test step; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs ✅ Passed The change only enables go-verify-deps; its script logs dependency/vendor status and contains no password/token/PII logging.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simkam
Once this PR has been reviewed and has the lgtm label, please assign theobarberbany for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from nrb and theobarberbany July 30, 2026 12:34
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@simkam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-capi-operator-main-verify-deps openshift/cluster-capi-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@simkam

simkam commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-verify-deps

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simkam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@simkam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-capi-operator/main/verify-deps e8897c2 link unknown /pj-rehearse pull-ci-openshift-cluster-capi-operator-main-verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simkam

simkam commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@simkam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-capi-operator/main/verify-deps e8897c2 link unknown /pj-rehearse pull-ci-openshift-cluster-capi-operator-main-verify-deps

Full PR test history. Your PR dashboard.
Details

it is expected to fail until openshift/cluster-capi-operator#639 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant