fix(odf-operator): respect explicit ODF_OPERATOR_SUB_CHANNEL over der… - #82666
fix(odf-operator): respect explicit ODF_OPERATOR_SUB_CHANNEL over der…#82666mgencur wants to merge 1 commit into
Conversation
…ived value When a custom CatalogSource is found, the script derived the ODF subscription channel from the CatalogSource name, overriding any explicitly set ODF_OPERATOR_SUB_CHANNEL. Guard the derivation with an emptiness check so that an explicit channel value takes precedence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThe ODF subscription step now defaults its channel to empty and derives a ChangesODF channel selection
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 130 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Hey @aleskandro , could you please tag this? It's the same change as you already tagged in #81194 (comment) |
|
@mgencur: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
…ived value
When a custom CatalogSource is found, the script derived the ODF subscription channel from the CatalogSource name, overriding any explicitly set ODF_OPERATOR_SUB_CHANNEL. Guard the derivation with an emptiness check so that an explicit channel value takes precedence.
Summary by CodeRabbit
Updates ODF Operator CI subscription configuration so an explicitly provided
ODF_OPERATOR_SUB_CHANNELtakes precedence. When unset, the channel is derived from a customredhat-operatorsCatalogSource name; otherwise, no default channel overrides the supplied value.