[DNM] Sync Serverless CI config/#81603
Closed
maschmid wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
Contributor
WalkthroughThis PR is a large-scale automated regeneration of ci-operator release configuration YAML files across many openshift-knative repositories. Changes include bumping OCP versions to 4.22/5.0, switching release vs candidate channel selection, adding/removing skip_if_only_changed and promotion rules, and converting test workflows between ipi-aws/cluster_profile and generic-claim/cluster_claim styles with added cron scheduling and reporter configs. ChangesCI Operator Release Config Updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
|
Contributor
|
[REHEARSALNOTIFIER]
A total of 213 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
Author
|
/pj-rehearse pull-ci-openshift-knative-serverless-operator-main-422-operator-e2e pull-ci-openshift-knative-serverless-operator-main-50-operator-e2e periodic-ci-openshift-knative-serverless-operator-release-1.37-ocp-5.0-lpGA-lp-ocp-compat-cr--operator-e2e--aws |
Contributor
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__422.yaml`:
- Line 27: The skip_if_only_changed pattern is too broad because the leading dot
in the hidden directories is treated as a wildcard and the markdown match is not
end-anchored. Update the regex in the release config to escape the literal dots
for .tekton, .konflux, and .github, and anchor the markdown rule so it only
matches files ending in .md. Keep the existing behavior for the hack, OWNERS,
and rpms.lock.yaml paths while tightening the matching in this configuration
key.
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yaml`:
- Line 27: The skip_if_only_changed pattern is too broad because the leading
dots in .tekton, .konflux, and .github are acting as wildcards, and the markdown
matcher is not anchored to the end. Update the regex in the release config entry
to escape the literal dots for those path prefixes and tighten the markdown rule
so it only matches files ending in .md, keeping the rest of the skip logic in
the same pattern.
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22__422.yaml`:
- Line 27: The skip_if_only_changed pattern is too broad because the leading dot
in the .tekton, .konflux, and .github path checks is acting as a wildcard, and
the markdown matcher is not anchored. Update the regex in the release config to
escape those literal dot-prefixed directories/files and tighten the markdown
match so it only skips .md files, using the skip_if_only_changed entry as the
target to adjust.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__422.yaml`:
- Line 73: The root-level job filter is currently nested under images, so move
skip_if_only_changed out of the images block in the
openshift-knative-client-release-v1.17 configuration. Keep the setting at the
top level alongside the CI job fields so it is parsed as a job property rather
than images.skip_if_only_changed, and verify the images section only contains
image-related keys.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__50.yaml`:
- Line 73: The presubmit trigger configuration is nested incorrectly under the
images block, so run_if_changed is being treated as images.run_if_changed
instead of a job-level setting. Move run_if_changed out of the images section in
the affected config so it is parsed as a CI job property alongside always_run
and the other top-level presubmit fields.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__422.yaml`:
- Line 73: The `skip_if_only_changed` setting is nested under `images` in the
release config, so it is being parsed as an image-level field instead of a
top-level CI job filter. Move `skip_if_only_changed` out to the root of the
config in the `openshift-knative-client-release-v1.21__422.yaml` definition so
it applies to the job itself, and keep the existing regex value unchanged.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__50.yaml`:
- Line 73: The presubmit gate is being parsed as images.run_if_changed because
run_if_changed is nested under images, so move run_if_changed to the top-level
job configuration alongside always_run in the
openshift-knative-client-release-v1.21__50.yaml config. Update the job stanza
for the relevant CI definition so the trigger condition is applied as a CI job
property rather than an image field.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.22__50.yaml`:
- Line 83: Move the run_if_changed gate out of the images block so it is treated
as the presubmit job-level setting instead of images.run_if_changed. Update the
relevant job definition in the release config so the gate sits alongside the
other top-level presubmit fields (for the same job that currently contains
always_run), preserving the intended trigger behavior when always_run is false.
In
`@ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__50.yaml`:
- Line 339: The release job configuration includes a duplicate deprovision ref
that is already covered by the ipi-aws workflow through chain: ipi-deprovision,
so remove the extra ipi-deprovision-deprovision entry from this config. Update
the YAML around the affected job definition so only the workflow-provided
cleanup remains, and keep the rest of the ipi-aws setup unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 658fb78c-888c-4aee-b89d-6ce38d9f0e7b
⛔ Files ignored due to path filters (70)
ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.22-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.22-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.22-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.22-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (66)
ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__422.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__50.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__50.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22__422.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22__50.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__422.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__50.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__422.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__50.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.22__422.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.22__50.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17__50.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21__50.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__50.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__414.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__50.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__50.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__50.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__50.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17__422.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17__50.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.21__422.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.22__422.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next__422.yamlci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17__422.yamlci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17__50.yamlci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.21__422.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17__422.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17__50.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21__422.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21__50.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.22__422.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.22__50.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17__422.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17__50.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21__422.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21__50.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.22__422.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.22__50.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__4.22-techpreview.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422-aws-ovn.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422-azure.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422-gcp.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422-hypershift.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422-single-node.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422-vsphere.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__50.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__422.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__50.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__ocp-5.0-lpGA-lp-ocp-compat.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__422.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__50.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__422.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__50.yaml
💤 Files with no reviewable changes (2)
- ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml
- ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml
| from: src | ||
| to: knative-backstage-plugins-source-image | ||
| run_if_changed: ^non-existing$ | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Tighten the skip regex before it skips unrelated paths.
The leading . in .tekton, .konflux, .github, and rpms.lock.yaml is currently a wildcard, and .*\.md is not end-anchored.
Proposed fix
- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+ skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | |
| skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__422.yaml`
at line 27, The skip_if_only_changed pattern is too broad because the leading
dot in the hidden directories is treated as a wildcard and the markdown match is
not end-anchored. Update the regex in the release config to escape the literal
dots for .tekton, .konflux, and .github, and anchor the markdown rule so it only
matches files ending in .md. Keep the existing behavior for the hack, OWNERS,
and rpms.lock.yaml paths while tightening the matching in this configuration
key.
| from: src | ||
| to: knative-backstage-plugins-source-image | ||
| run_if_changed: ^non-existing$ | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Tighten the skip regex before it skips unrelated paths.
The leading . in .tekton, .konflux, .github, and rpms.lock.yaml is currently a wildcard, and .*\.md is not end-anchored.
Proposed fix
- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+ skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | |
| skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yaml`
at line 27, The skip_if_only_changed pattern is too broad because the leading
dots in .tekton, .konflux, and .github are acting as wildcards, and the markdown
matcher is not anchored to the end. Update the regex in the release config entry
to escape the literal dots for those path prefixes and tighten the markdown rule
so it only matches files ending in .md, keeping the rest of the skip logic in
the same pattern.
| from: src | ||
| to: knative-backstage-plugins-source-image | ||
| run_if_changed: ^non-existing$ | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Tighten the skip regex before it skips unrelated paths.
The leading . in .tekton, .konflux, .github, and rpms.lock.yaml is currently a wildcard, and .*\.md is not end-anchored.
Proposed fix
- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+ skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | |
| skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22__422.yaml`
at line 27, The skip_if_only_changed pattern is too broad because the leading
dot in the .tekton, .konflux, and .github path checks is acting as a wildcard,
and the markdown matcher is not anchored. Update the regex in the release config
to escape those literal dot-prefixed directories/files and tighten the markdown
match so it only skips .md files, using the skip_if_only_changed entry as the
target to adjust.
| from: src | ||
| to: knative-client-source-image | ||
| run_if_changed: ^non-existing$ | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Move the job filter out of images.
Line 73 is indented under images, so the intended root-level skip_if_only_changed is parsed as images.skip_if_only_changed instead of a CI job property.
Proposed fix
- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | |
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__422.yaml`
at line 73, The root-level job filter is currently nested under images, so move
skip_if_only_changed out of the images block in the
openshift-knative-client-release-v1.17 configuration. Keep the setting at the
top level alongside the CI job fields so it is parsed as a job property rather
than images.skip_if_only_changed, and verify the images section only contains
image-related keys.
| from: src | ||
| to: knative-client-source-image | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||
| run_if_changed: ^non-existing$ |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Move run_if_changed out of images.
Line 73 is nested under images, so the gate is parsed as images.run_if_changed rather than a CI job property; with always_run: false, that can change when the presubmit is triggered.
Proposed fix
- run_if_changed: ^non-existing$
+run_if_changed: ^non-existing$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| run_if_changed: ^non-existing$ | |
| run_if_changed: ^non-existing$ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__50.yaml`
at line 73, The presubmit trigger configuration is nested incorrectly under the
images block, so run_if_changed is being treated as images.run_if_changed
instead of a job-level setting. Move run_if_changed out of the images section in
the affected config so it is parsed as a CI job property alongside always_run
and the other top-level presubmit fields.
| from: src | ||
| to: knative-client-source-image | ||
| run_if_changed: ^non-existing$ | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Move the job filter out of images.
Line 73 is indented under images, so the intended root-level skip_if_only_changed is parsed as images.skip_if_only_changed instead of a CI job property.
Proposed fix
- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | |
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__422.yaml`
at line 73, The `skip_if_only_changed` setting is nested under `images` in the
release config, so it is being parsed as an image-level field instead of a
top-level CI job filter. Move `skip_if_only_changed` out to the root of the
config in the `openshift-knative-client-release-v1.21__422.yaml` definition so
it applies to the job itself, and keep the existing regex value unchanged.
| from: src | ||
| to: knative-client-source-image | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||
| run_if_changed: ^non-existing$ |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Move run_if_changed out of images.
Line 73 is nested under images, so the gate is parsed as images.run_if_changed rather than a CI job property; with always_run: false, that can change when the presubmit is triggered.
Proposed fix
- run_if_changed: ^non-existing$
+run_if_changed: ^non-existing$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| run_if_changed: ^non-existing$ | |
| run_if_changed: ^non-existing$ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__50.yaml`
at line 73, The presubmit gate is being parsed as images.run_if_changed because
run_if_changed is nested under images, so move run_if_changed to the top-level
job configuration alongside always_run in the
openshift-knative-client-release-v1.21__50.yaml config. Update the job stanza
for the relevant CI definition so the trigger condition is applied as a CI job
property rather than an image field.
| from: src | ||
| to: knative-client-source-image | ||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||
| run_if_changed: ^non-existing$ |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Move run_if_changed out of images.
Line 83 is nested under images, so the gate is parsed as images.run_if_changed rather than a CI job property; with always_run: false, that can change when the presubmit is triggered.
Proposed fix
- run_if_changed: ^non-existing$
+run_if_changed: ^non-existing$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| run_if_changed: ^non-existing$ | |
| run_if_changed: ^non-existing$ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.22__50.yaml`
at line 83, Move the run_if_changed gate out of the images block so it is
treated as the presubmit job-level setting instead of images.run_if_changed.
Update the relevant job definition in the release config so the gate sits
alongside the other top-level presubmit fields (for the same job that currently
contains always_run), preserving the intended trigger behavior when always_run
is false.
| cpu: 300m | ||
| memory: 300Mi | ||
| timeout: 20m0s | ||
| - ref: ipi-deprovision-deprovision |
Contributor
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Inspect the ipi-aws workflow and deprovision references without executing repo code.
fd -i 'ipi-aws.*workflow.*ya?ml|ipi-deprovision.*ya?ml' ci-operator/step-registry --exec sh -c '
echo "===== $1 ====="
sed -n "1,180p" "$1"
' sh {}Repository: openshift/release
Length of output: 32266
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== target config around lines 320-430 =="
sed -n '320,430p' ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__50.yaml
echo
echo "== ipi-aws post chain =="
fd -a 'ipi-aws-post*' ci-operator/step-registry | while read -r f; do
echo "===== $f ====="
sed -n '1,220p' "$f"
done
echo
echo "== deprovision chain =="
sed -n '1,120p' ci-operator/step-registry/ipi/deprovision/ipi-deprovision-chain.yamlRepository: openshift/release
Length of output: 7445
Remove the duplicate deprovision step — workflow: ipi-aws already runs chain: ipi-deprovision, which includes ref: ipi-deprovision-deprovision, so this extra ref will tear down the cluster twice and can make cleanup flaky.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__50.yaml`
at line 339, The release job configuration includes a duplicate deprovision ref
that is already covered by the ipi-aws workflow through chain: ipi-deprovision,
so remove the extra ipi-deprovision-deprovision entry from this config. Update
the YAML around the affected job definition so only the workflow-provided
cleanup remains, and keep the rest of the ipi-aws setup unchanged.
Contributor
|
@maschmid: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge, rehearsing changes from openshift-knative/hack#993
Summary by CodeRabbit
This PR updates generated CI operator config for multiple OpenShift Knative component repos to align release-v1.17/v1.21/v1.22 and release-1.37 jobs with newer OpenShift 4.22/5.0 targeting. In practical terms, it reshapes when jobs run, what release stream they track, and how images are promoted for downstream Knative components.
Key changes include:
run_if_changedandskip_if_only_changedgating.fastrelease targeting in some branches, and vice versa in others.ipi-awsandgeneric-claim, including cluster claim settings, cron/reporting, and post-step behavior.One large eventing-istio v1.17 variant was removed, while corresponding v1.17/v1.21/v1.22 variants were refreshed to match the new CI layout.