Fix tests-private-base/baseui DockerBuildFailed on release-4.18 and r…#80257
Fix tests-private-base/baseui DockerBuildFailed on release-4.18 and r…#80257pruan-rht wants to merge 1 commit into
Conversation
…elease-4.20 release-4.18: Add ENV ART_DNF_WRAPPER_POLICY=append to tests-private-base and tests-private-baseui dockerfile_literal blocks so the ART yum/dnf wrapper also searches /etc/yum.repos.d/, enabling local RPM installs (google-chrome) and external repo access (azure-cli, google-cloud-cli, nodesource). release-4.20: Replace yum config-manager --disable with inline --disablerepo= flags on yum update/install commands, matching the pattern used by 4.21 and 4.22. The yum config-manager subcommand requires dnf-plugins-core which is no longer pre-installed in the 4.20 tools base image.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR updates CI operator configurations for two OpenShift release versions: adding a DNF wrapper policy environment variable to test builder stages in release 4.18, and refactoring how repository disabling works in the tools image build for release 4.20 by applying flags directly to yum commands instead of using a configuration manager. ChangesCI Operator Configuration Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pruan-rht The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 937 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@pruan-rht: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
…elease-4.20
release-4.18: Add ENV ART_DNF_WRAPPER_POLICY=append to tests-private-base and tests-private-baseui dockerfile_literal blocks so the ART yum/dnf wrapper also searches /etc/yum.repos.d/, enabling local RPM installs (google-chrome) and external repo access (azure-cli, google-cloud-cli, nodesource).
release-4.20: Replace yum config-manager --disable with inline --disablerepo= flags on yum update/install commands, matching the pattern used by 4.21 and 4.22. The yum config-manager subcommand requires dnf-plugins-core which is no longer pre-installed in the 4.20 tools base image.
Summary by CodeRabbit
This PR addresses Docker build failures in the openshift-tests-private CI configuration across two release branches by fixing package repository access issues.
Release 4.18 Changes:
ENV ART_DNF_WRAPPER_POLICY=appendto the Dockerfile definitions for both thetests-private-baseandtests-private-baseuibuilder images/etc/yum.repos.d/directory, which allows:Release 4.20 Changes:
yum config-manager --disablecalls with inline--disablerepo=flags on bothyum updateandyum installcommandsyum config-managersubcommand requires thednf-plugins-corepackage, which is no longer pre-installed in the 4.20 tools base imageBoth changes fix Docker build failures (DockerBuildFailed) by resolving repository and package installation issues in the test infrastructure images.