Skip to content

[Do not Merge]5.0 on rhel 10#80250

Open
kapjain-rh wants to merge 1 commit into
openshift:mainfrom
kapjain-rh:netobserv-5.0
Open

[Do not Merge]5.0 on rhel 10#80250
kapjain-rh wants to merge 1 commit into
openshift:mainfrom
kapjain-rh:netobserv-5.0

Conversation

@kapjain-rh

@kapjain-rh kapjain-rh commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates the Network Observability (netobserv) operator's CI configuration to target OpenShift 5.0 with RHEL CoreOS 10 support.

The changes affect two CI configuration files:

  1. Main operator CI configuration - Updates the candidate OCP release version from 4.21 to 5.0 and configures the CI environment to use RHEL CoreOS 10 as the machine OS content for test environments.

  2. Performance tests CI configuration - Adds machine OS content configuration to specify RHEL CoreOS 10 for the nightly AWS 5.0 performance test pipeline.

These changes align the netobserv operator's CI infrastructure with the new OCP 5.0 baseline running on RHEL 10, ensuring the operator is tested against the appropriate OS and release versions.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c3fd7ebc-86de-43ff-a724-5610e69e0cad

📥 Commits

Reviewing files that changed from the base of the PR and between 16971ab and 3c50bb2.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/netobserv/netobserv-operator/netobserv-netobserv-operator-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/netobserv/netobserv-operator/netobserv-netobserv-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yaml
  • ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-5.0-nightly-x86.yaml

Walkthrough

Two CI operator configuration files are updated to target RHEL CoreOS 5.0. The netobserv-operator config updates machine-os-content image references and bumps the release candidate version to 5.0. The netobserv-perf-tests config adds a corresponding machine-os-content configuration block.

Changes

RHEL CoreOS 5.0 Target Update

Layer / File(s) Summary
netobserv-operator config machine-os-content and release version
ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yaml
Machine-os-content in cli-operator-sdk base images updated from previous content to name "5.0" with tag rhel-coreos-10 (namespace ocp), and releases.latest.candidate.version bumped from "4.21" to "5.0" for alignment.
netobserv-perf-tests config machine-os-content
ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-5.0-nightly-x86.yaml
Machine-os-content configuration block added with name "5.0", namespace ocp, and tag rhel-coreos-10 in base images definitions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

ok-to-test

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '[Do not Merge]5.0 on rhel 10' is partially related to the changeset—it mentions the version (5.0) and OS (rhel 10) being updated, which are real aspects of the changes. However, it lacks specificity about the main change and includes a '[Do not Merge]' prefix that indicates the PR status rather than describing the actual modifications made. Improve clarity by removing the '[Do not Merge]' prefix and making the title more descriptive of the actual changes, such as 'Update netobserv configs to target RHEL CoreOS 5.0' or similar.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI configuration files with no Ginkgo test definitions. This check is not applicable as no test code is modified.
Test Structure And Quality ✅ Passed This PR contains CI operator configuration YAML files and standard Go tests (testing.T), not Ginkgo test code. The check for Ginkgo test quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies CI operator configuration YAML files and repository tools, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR modifies only CI operator YAML configuration files, not Ginkgo e2e test code. No new tests are added, so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI operator configuration files (base_images, releases, build settings) with no deployment manifests, operator code, or controllers that could introduce scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI operator configuration files with no executable code; OTE Binary Stdout Contract check is not applicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR contains only CI-Operator YAML configuration changes, not Ginkgo e2e test code. No new tests (It(), Describe(), Context(), etc.) were added, so the check does not apply.
No-Weak-Crypto ✅ Passed No weak cryptographic algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant-time secret comparisons detected in the PR changes.
Container-Privileges ✅ Passed The modified CI operator files contain no privileged container settings like privileged: true, hostPID, hostNetwork, hostIPC, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only add/modify YAML configuration values (OS content references, version strings). No new logging code, echo statements, or sensitive data exposure is introduced by these changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jpinsonneau and luisjira June 8, 2026 19:00
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kapjain-rh
Once this PR has been reviewed and has the lgtm label, please assign leandroberetta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kapjain-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-netobserv-netobserv-operator-main-ci-bundle-noo-bundle netobserv/netobserv-operator presubmit Ci-operator config changed
pull-ci-netobserv-netobserv-operator-main-e2e-operator netobserv/netobserv-operator presubmit Ci-operator config changed
pull-ci-netobserv-netobserv-operator-main-images netobserv/netobserv-operator presubmit Ci-operator config changed
pull-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-5.0-nightly-x86-images netobserv/netobserv-perf-tests presubmit Ci-operator config changed
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-5.0-nightly-x86-cluster-density-v2-250nodes N/A periodic Ci-operator config changed
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-5.0-nightly-x86-node-density-heavy-25nodes N/A periodic Ci-operator config changed
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-5.0-nightly-x86-node-density-heavy-25nodes-service-without-loki N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@kapjain-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config-metadata 3c50bb2 link true /test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant